You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2021/02/17 00:04:54 UTC
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17072
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
IMPALA-10389: (supplement) Add impala-profile-tool to build by default
This just adds the impala-profile-tool to the list of regular make
targets that will be built by default. It helps streamline automated
build jobs that also verify docker builds.
Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/17072/1
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17072 )
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
Patch Set 1: Code-Review+2
This makes sense to me.
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 00:11:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17072 )
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 00:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17072 )
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
IMPALA-10389: (supplement) Add impala-profile-tool to build by default
This just adds the impala-profile-tool to the list of regular make
targets that will be built by default. It helps streamline automated
build jobs that also verify docker builds.
Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Reviewed-on: http://gerrit.cloudera.org:8080/17072
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Bikramjeet Vig <bi...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Bikramjeet Vig: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17072 )
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8142/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 00:25:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10389: (supplement) Add impala-profile-tool to build by default
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/17072 )
Change subject: IMPALA-10389: (supplement) Add impala-profile-tool to build by default
......................................................................
Patch Set 1:
Since this is a trivial change, I am merging this without a GVO
--
To view, visit http://gerrit.cloudera.org:8080/17072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I58d8392d19b04aceb06874056cb2ffc5d22ca673
Gerrit-Change-Number: 17072
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Feb 2021 00:40:17 +0000
Gerrit-HasComments: No