You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by roshannaik <gi...@git.apache.org> on 2017/01/27 02:22:02 UTC
[GitHub] storm pull request #1898: STORM 2324 - Fix toplogy deployment failure if res...
GitHub user roshannaik opened a pull request:
https://github.com/apache/storm/pull/1898
STORM 2324 - Fix toplogy deployment failure if resources directory is missing in topology jar
Skips creating symlink to the resources directory if there is no target resources directory.
This avoids failure in setup_permissions() function in worker_launcher.c
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/roshannaik/storm STORM-2324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1898.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1898
----
commit 016fceae83c9a38cd624bfd46f11b96b9976068d
Author: Roshan Naik <ro...@hortonworks.com>
Date: 2017-01-27T00:51:37Z
STORM-2324 : Making sure toplogy deployment does not break if resources directory is missing in topology jar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1898: STORM 2324 - Fix toplogy deployment failure if res...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1898
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1898
@roshannaik I am facing the following unit test failure after merging in the patch
{code}
Wanted but not invoked:
advancedFSOps.createSymlink(
/tmp/testing/workers/worker_id/resources,
/tmp/testing/supervisor/stormdist/test_topology/resources
);
-> at org.apache.storm.daemon.supervisor.ContainerTest.testSetup(ContainerTest.java:218)
However, there were other interactions with this mock:
-> at org.apache.storm.daemon.supervisor.Container.<init>(Container.java:131)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:301)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:308)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:309)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:310)
-> at org.apache.storm.daemon.supervisor.Container.setup(Container.java:313)
-> at org.apache.storm.daemon.supervisor.Container.getWorkerUser(Container.java:452)
-> at org.apache.storm.daemon.supervisor.Container.writeLogMetadata(Container.java:368)
-> at org.apache.storm.daemon.supervisor.Container.saveWorkerUser(Container.java:471)
-> at org.apache.storm.daemon.supervisor.Container.createArtifactsLink(Container.java:381)
-> at org.apache.storm.daemon.supervisor.Container.createArtifactsLink(Container.java:383)
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1898
@roshannaik not sure if we can cherry-pick this into master. Do you want to open another PR against master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1898
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1898
I'm +1 given that you tested this manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by roshannaik <gi...@git.apache.org>.
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/1898
will take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by roshannaik <gi...@git.apache.org>.
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/1898
Looks like there are additional UTs which also need updating....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by roshannaik <gi...@git.apache.org>.
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/1898
ok only 1 test needed fix... the others storm-core test are ok ... were failing only if I ran within IDE due to relative paths issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1898
+1 UT passed from local dev.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1898: STORM 2324 - Fix toplogy deployment failure if resources ...
Posted by roshannaik <gi...@git.apache.org>.
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/1898
Thanks for reviewing. Here is the PR for master branch ...
https://github.com/apache/storm/pull/1908
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---