You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/10/02 10:47:01 UTC

[GitHub] [zookeeper] tisonkun commented on pull request #1905: ZOOKEEPER-4575: ZooKeeperServer#processPacket take record instead of bytes

tisonkun commented on PR #1905:
URL: https://github.com/apache/zookeeper/pull/1905#issuecomment-1264611113

   > Should we fear of any performance degradation? I think it is unlikely, but I haven't spent enough time on the PR to be sure and want to hear your opinion.
   
   @symat I don't have to completed performance coverage on this change. From the code change perspective:
   
   1. `RequestRecord` (`ByteBufferRequestRecord`) is a semantically identical refactoring over current codebase.
   2. About changing about the deserialization part during `PrepProcessor`, see https://github.com/apache/zookeeper/pull/1905#discussion_r962137523.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org