[GitHub] [trafficcontrol] mitchell852 commented on issue #3931: Gives admins the ability to mark delivery service requests as complete

[GitBox <gi...@apache.org>]

mitchell852 commented on issue #3931: Gives admins the ability to mark delivery service requests as complete
URL: https://github.com/apache/trafficcontrol/pull/3931#issuecomment-538470831
 
 
   > So it looks like this protection for who can and can't fulfill a request is entirely front-end - why isn't that enforced by the API?
   
   I agree 100%. Here's some history. Delivery service requests were intended to be a short-lived feature so it's less than perfect imo. Full self-service was to take its place at some point.
   
   These are the valid statuses of a DSR: draft, submitted, pending, complete, rejected. 
   
   The creator of a DSR needs to put the DSR in draft or submitted (DSRs in draft cannot be fulfilled, DSRs in submitted status are ready for review/fulfillment), therefore, the permission level for updating DSR status is "portal" but that allows portal users to mark DSRs as "complete or rejected" which doesn't make a lot of sense. That part is really the job of the reviewer.
   
   Anyhow, long story, short the design of `PUT deliveryservice_requests/{id}/status` was probably not very good hence the UI is doing half the job.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services