[jira] Commented: (HADOOP-6286) The Glob methods in FileContext doe not deal with URIs correctly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762790#action_12762790 ] 

Hadoop QA commented on HADOOP-6286:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12421449/HADOOP-6286-3.patch
  against trunk revision 820094.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/72/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/72/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/72/console

This message is automatically generated.

> The Glob methods in FileContext doe not deal with URIs correctly
> ----------------------------------------------------------------
>
>                 Key: HADOOP-6286
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6286
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0
>            Reporter: Sanjay Radia
>            Assignee: Boris Shkolnik
>         Attachments: HADOOP-6286-1.patch, HADOOP-6286-1.patch, HADOOP-6286-2.patch, HADOOP-6286-3.patch, HADOOP-6286.patch
>
>
> The glob methods in FileContext were copied from FileSystem where they dealt with the a single filesystem.
> While they were extended to fit in FileContext they don't seem to deal with URI pathnames correctly.
> For example the following two lines in FileContext may be the source of the problem - the scheme and authority seem to be 
> ignored beyond these points. 
> line 1013: String filename = pathPattern.toUri().getPath();
> line 1035:  String filename = pathPattern.toUri().getPath();

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.