[GitHub] [arrow] pitrou commented on a change in pull request #10619: Sketch of a general purpose cython trampolining utility

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #10619:
URL: https://github.com/apache/arrow/pull/10619#discussion_r660774414



##########
File path: python/pyarrow/tests/test_dataset.py
##########
@@ -3397,3 +3404,13 @@ def test_dataset_null_to_dictionary_cast(tempdir, dataset_reader):
     )
     table = dataset_reader.to_table(fsds)
     assert table.schema == schema
+
+
+def test_visit_strings_adhoc():
+    import pyarrow._dataset as _ds
+
+    strings = ['a', 'b', 'c']
+    visited = []
+    _ds._visit_strings(strings, visited.append)

Review comment:
       Also test a failing callback?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org