[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #675: [WIP] Inherit snapshot ids

[GitBox <gi...@apache.org>]

chenjunjiedada commented on a change in pull request #675: [WIP] Inherit snapshot ids
URL: https://github.com/apache/incubator-iceberg/pull/675#discussion_r360634578
 
 

 ##########
 File path: core/src/main/java/org/apache/iceberg/ManifestEntry.java
 ##########
 @@ -170,7 +175,7 @@ static Schema wrapFileSchema(StructType fileStruct) {
     // ids for top-level columns are assigned from 1000
     return new Schema(
         required(0, "status", IntegerType.get()),
-        required(1, "snapshot_id", LongType.get()),
+        optional(1, "snapshot_id", LongType.get()),
 
 Review comment:
   I see, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org