You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/01 21:56:45 UTC
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #6092: Flink: Add support for Flink 1.16
stevenzwu commented on code in PR #6092:
URL: https://github.com/apache/iceberg/pull/6092#discussion_r1010939194
##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkTableSource.java:
##########
@@ -602,53 +602,8 @@ public void testFilterPushDown2Literal() {
"Should not push down a filter", Expressions.alwaysTrue(), lastScanEvent.filter());
}
- /**
- * NaN is not supported by flink now, so we add the test case to assert the parse error, when we
- * upgrade the flink that supports NaN, we will delele the method, and add some test case to test
- * NaN.
- */
- @Test
- public void testSqlParseError() {
- String sqlParseErrorEqual =
- String.format("SELECT * FROM %s WHERE d = CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorEqual));
-
- String sqlParseErrorNotEqual =
- String.format("SELECT * FROM %s WHERE d <> CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorNotEqual));
-
- String sqlParseErrorGT =
- String.format("SELECT * FROM %s WHERE d > CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGT));
-
- String sqlParseErrorLT =
- String.format("SELECT * FROM %s WHERE d < CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLT));
-
- String sqlParseErrorGTE =
- String.format("SELECT * FROM %s WHERE d >= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorGTE));
-
- String sqlParseErrorLTE =
- String.format("SELECT * FROM %s WHERE d <= CAST('NaN' AS DOUBLE) ", TABLE_NAME);
- AssertHelpers.assertThrows(
- "The NaN is not supported by flink now. ",
- NumberFormatException.class,
- () -> sql(sqlParseErrorLTE));
+ @Test
+ public void testSqlParseNaN() {
+ // todo add some test case to test NaN
Review Comment:
do you plan to fix it in this PR or will do it in a follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org