You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ro...@apache.org on 2022/08/18 17:21:30 UTC
[activemq-artemis] branch new-logging updated (fbe5b0a222 -> 8ae5e8797a)
This is an automated email from the ASF dual-hosted git repository.
robbie pushed a change to branch new-logging
in repository https://gitbox.apache.org/repos/asf/activemq-artemis.git
discard fbe5b0a222 remove uses of JBL from compatibility tests, add artemis-unit-test-support to snapshots CP to ensure test appender class is found and avoids stacktracing
discard c560e160e5 remove now-stale comments missed in previous clearup when switching to cp files
discard 1db15a5b08 add another TODO note
discard fa9bec3476 move another old log config file out to root, for any later comparisons needed
discard e0874645db remove a couple of properties that override parent definitions and break use of the e2e-tests profile
discard 4145dc9e12 replace logging.properties files for e2e-tests server configs
discard 2a24f9cc0e remove commons-logging slf4j bridge now the karaf bits dont cause beanutils log spam
discard 4e29a7f48f move karaf server feature test to its own module, its logging deps mess with the commons-config handling
discard 535552f6fc delete old Log4J 1.x log4j.properties files that shouldnt be doing anything, build isnt using log4j 1.x / reload4j anymore
discard fc8988132d update deps to match actual SLF4J base usage and simplify
discard 0379a773a5 use latest log4j version
discard f2d80e4584 remove now-unused import
discard 7375959ece update notes
discard 6c6d8b238f remove rather than reinstate a couple of unnecesarry level manipulations
discard b1e4f9e8d0 ensure method or class based cleanups for AssertionLoggerHandler exist or will be effective, where startCapture() has been called previously
discard 7cd51416c1 reinstate another test manipulating levels
discard 157140b9df restore one of the remaining tests using JBL, manipulating levels
discard 4f1717afe3 Revert "add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc"
discard a0572f78cb Revert "Moving dependencies as test"
discard 75fcf25ea2 Revert "Remove slf4j bridge depedencies from libs", towards getting build back to consistent deps state and to more easily revert original addition leading to issue.
discard bcf86ce869 fixing build after rebase
discard fa11c13b5c Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
discard 3e3e73af44 fixing test
discard ab6c16c0d2 Moving dependencies as test
discard 26a3786069 Remove slf4j bridge depedencies from libs
discard a3065231ed Removing log facade package
discard 62116638d4 make start on updating remaining integration tests, manipulating levels etc
discard fcbfae638a remove various mentions of jblm and wildfly-common from scripts etc, update service config logging details..now to see what it breaks
discard 254766b08e also move the old main tests logging.config file
discard 8e74efa970 move old base logging.properties out of artemis-cli, but leave it in root for comparison to see needed config updates as others replaced
discard ab6e2ac80a add some TODOs for area cleanup still needed
discard 5689f3ea03 change remaining integration tests except those with TODOs
discard 762c2074aa Adding safeguard against {?} on LogProcessor
discard 97708ccab5 fix compile issues IDE somehow decided not to show
discard 13c6a20ca1 more test changes
discard 886605e783 more test updates
discard 52652497b3 some more integration test updates
discard 0b6d33473c make start on updating integration tests
discard 4516cdba04 add note about e2e-test fixups needed
discard 5d12fa7106 add artemis-unit-test-support dep to various modules that have tests, avoid stacktrace on not finding appender from shared logging config
discard 57ea570fbd Verifying JMX Security and setting up javax.management.builder.initial before Log4J starts its own JMX
discard 0c2a0dcfa0 add artemis-unit-test-support dep to various modules that have tests, and will stacktrace if the appender isnt found which is referenced in their shared logging test config
discard eb5e1293bd fix dep scope
discard 21c180ce25 add note about many integration-tests etc still using JBL
discard f569445675 fix other files similar to commit titled 'Fixing duplicate properties'
discard 325bd51c5f Fixing duplicate properties
discard acf7a92087 Setting version as 3.0.0
discard 9d70a4dc7e updating version after rebasing
discard f3194a94b9 add log config to get NettyNativeTest working
discard 214fb3cf14 simplify test logging config again, adjust assertion to be more specific and take into account change in output from 07329118c10d14bce018a580b0dadbcf081233a8
discard 34acd76a70 add log config for AuditLoggerAMQPMutualSSLTest
discard 62e0444d32 ARTEMIS-3902 Adding Reason to Security Exception
discard f93b19efcb add some TODO notes from memory
discard b201d8ce7c add some [in-flux] config to get more failing audit log smoke tests passing
discard c6f7dde388 apply needed change only, and remove old unused logging.properties file
discard a8fb84c526 reset smoke test config to current base assembly config
discard fa6f1caad4 some more helper additions to bring default assembly logging config into line with prior config
discard 4f0774f363 Adding a test with no argument on exception (just to be sure)
discard 59c75556e3 Removing @Cause annotation
discard bc8704dfb7 fix up errorprone error and an IDE warning
discard fa6b013f0f ensure exceptions/causes are the last arg passed, as the logging framework expects, and processor now enforces
discard c56ace0693 fix checkstyle on processor
discard 86b17b1000 small tweak on test
discard c1b8e8e58b Enforcing exception as the last argument
discard f1c9f54665 log processing improvement with exceptions
discard fd3c063a34 flesh out assembly default logging config, give output like previous behaviour
discard 1881ed666c Removing Reload4J
discard d1468760e7 fix some more placeholders missed previously
discard 27dbf611c6 make basic start on audit log file config, add [unfinished] config changes to get AuditLoggerResourceTest smoke test passing
discard 9aa73c4ded reorder args to match previously out-of-order placeholders, ensure new output matches previous
discard 07530d59a1 remove now-unnecessary quote escaping from log/message bundle format strings, giving same output as before switch to slf4j formatter
discard 4e431ceb58 switch to released 2.0.0 artemis-native dep
discard 694c13cbce Fixing up some {0} versus {}
discard f16670b41c re-enable GHA CI runs in the main repo, build now in state it can pass the PR test subset (except for d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it fail)
discard dcb57acf5b add TODO for another fun task
discard 90a86368e8 fix various test failures due to unexpected message string; also make some tests indicate why they failed
discard 977c06b794 temporarily remove test to allow concentrating on other issues
discard efb9667be9 fix test missed in prior change
discard c03233ee2e fix format of code prefix in messages, pointed out by failing test
discard 11547944ed make a start on a basic loging config for distribution
discard 3176780f80 add some more needed deps; essentially every module with tests (or without specific log test config) will need this to avoid a stacktrace from logging setup issues
discard cbc4f81705 avoid NPE in a unit test due to audit loggers still being enabled, unlike prior test logging config
discard 3ffd5eea82 Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
discard 1080fe06a9 add some deps needed/used already, look into test failure
discard ca8268e7b1 fixup for release profile following prior rebases+squashes
discard f276e44561 add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc
discard 3e27e88916 basic logging config and some more on AssertionLoggerHandler to get some tests using it working
discard aa0936882e make a start on restoring AssertionLoggerHandler to get tests going
discard ff895083f5 Artemis native at 2.0 snapshot
discard 0e1ec15f05 squashed logging changes from Clebert + me, rebased onto main at 688b894c6205058c24d225b340aea1d8a5599902
add 4a7710918d NO-JIRA Moving HQ Converter into HQ client module
add dc2b67331d NO-JIRA update address-settings.md
add 382267bf63 This closes #4166
add 7fe3e5d198 ARTEMIS-3923 AddressControlImpl.getRoles doesn't return all the security role permissions.
add 174270fbc2 ARTEMIS-3914: reorder and clarify some bits, use version placeholder to give specific version in example dependency declaration
add ee8afc8131 This closes #4171
add 7ec0bd35ba ARTEMIS-3927: update postgresql [provided/test] dep to 42.4.1
add 12b81e7a25 ARTEMIS-3928 Adding SoakTest for Paging with in many destinations
add 568eb70fcd ARTEMIS-3929 Improving OpenWire clientIDSet
add 252e5b0b14 ARTEMIS-3928 Limiting parallel IO in paging which would allow multiple destinations running all at once
add 2fbf2fcef0 ARTEMIS-3928 Fixing intermittent failure after executor's change
add 520088b8c6 ARTEMIS-3940 Address.maxSizeMessage is ignored on FAIL and Blocking Paging Policy
add d158e7eff0 ARTEMIS-3925 LVQ pruning nulls
add aa11a82e0b This closes #4176
add 682f505e32 ARTEMIS-3942 use session instead of direct routing for MQTT LWT messages
add 05b3879cba This closes #4180
add 88be6c3223 ARTEMIS-3946: update to Netty 4.1.79 (and netty-tcnative to 2.0.54)
add 085bf79bf6 NO-JIRA: remove a couple of properties that override parent definitions and break use of the e2e-tests profile
add 0ca44c0e69 NO-JIRA: remove now-stale comments missed when switching to cp files in 71b781d9193c64e34e9d986939af40745ea9740b
new 4e50c840f0 squashed logging changes from Clebert + me, rebased onto main at 688b894c6205058c24d225b340aea1d8a5599902
new 35da8ef084 Artemis native at 2.0 snapshot
new 9c343afba6 make a start on restoring AssertionLoggerHandler to get tests going
new a99f7abd32 basic logging config and some more on AssertionLoggerHandler to get some tests using it working
new 643c43b893 add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc
new 9d998c6986 fixup for release profile following prior rebases+squashes
new 49e596146f add some deps needed/used already, look into test failure
new 6d385b4c8f Using Artemis Native 2.1.0 snapshot until 2.0.0 is released
new 8c4416abbc avoid NPE in a unit test due to audit loggers still being enabled, unlike prior test logging config
new 1f1e6ef1b1 add some more needed deps; essentially every module with tests (or without specific log test config) will need this to avoid a stacktrace from logging setup issues
new 5ddddc37b6 make a start on a basic loging config for distribution
new d31b73f96b fix format of code prefix in messages, pointed out by failing test
new dfbde76fda fix test missed in prior change
new f0b2754d81 temporarily remove test to allow concentrating on other issues
new 2f78510859 fix various test failures due to unexpected message string; also make some tests indicate why they failed
new e1c63ade71 add TODO for another fun task
new 95522d5bcb re-enable GHA CI runs in the main repo, build now in state it can pass the PR test subset (except for d153efde4e04703875c92fdcb45f9f65b87a215b needing reverted which would make it fail)
new 427172c08f Fixing up some {0} versus {}
new e5dcfc0062 switch to released 2.0.0 artemis-native dep
new 22a366e114 remove now-unnecessary quote escaping from log/message bundle format strings, giving same output as before switch to slf4j formatter
new b73b7806a3 reorder args to match previously out-of-order placeholders, ensure new output matches previous
new ea504a0d47 make basic start on audit log file config, add [unfinished] config changes to get AuditLoggerResourceTest smoke test passing
new 8d677667b2 fix some more placeholders missed previously
new 6137392b44 Removing Reload4J
new 57f910c679 flesh out assembly default logging config, give output like previous behaviour
new d0bb050b4c log processing improvement with exceptions
new 8bb2f9c703 Enforcing exception as the last argument
new dc5f2da3e8 small tweak on test
new 21ccb9e9e6 fix checkstyle on processor
new 86ec72e454 ensure exceptions/causes are the last arg passed, as the logging framework expects, and processor now enforces
new 620937cc76 fix up errorprone error and an IDE warning
new e5ff7898b5 Removing @Cause annotation
new 2ddff5be10 Adding a test with no argument on exception (just to be sure)
new ea20c6cc96 some more helper additions to bring default assembly logging config into line with prior config
new 300087f1ed reset smoke test config to current base assembly config
new 3c3831d497 apply needed change only, and remove old unused logging.properties file
new b2c443637d add some [in-flux] config to get more failing audit log smoke tests passing
new a7d41ccb51 add some TODO notes from memory
new bc616444dd ARTEMIS-3902 Adding Reason to Security Exception
new 5347ef1dea add log config for AuditLoggerAMQPMutualSSLTest
new 5285aab49b simplify test logging config again, adjust assertion to be more specific and take into account change in output from 07329118c10d14bce018a580b0dadbcf081233a8
new 1af97a6d42 add log config to get NettyNativeTest working
new 0096670dc2 updating version after rebasing
new 45525b6b13 Setting version as 3.0.0
new 31da1baeae Fixing duplicate properties
new c1d300ba4a fix other files similar to commit titled 'Fixing duplicate properties'
new 2febad9879 add note about many integration-tests etc still using JBL
new 9f20820f10 fix dep scope
new 6406adb1a5 add artemis-unit-test-support dep to various modules that have tests, and will stacktrace if the appender isnt found which is referenced in their shared logging test config
new a712ef436f Verifying JMX Security and setting up javax.management.builder.initial before Log4J starts its own JMX
new 7027029f87 add artemis-unit-test-support dep to various modules that have tests, avoid stacktrace on not finding appender from shared logging config
new 56a2b2af28 add note about e2e-test fixups needed
new 45f34eaa77 make start on updating integration tests
new 62451d9d32 some more integration test updates
new 92751e615f more test updates
new 47754ad947 more test changes
new 628199186d fix compile issues IDE somehow decided not to show
new bbe9e2724b Adding safeguard against {?} on LogProcessor
new 7b43f29e41 change remaining integration tests except those with TODOs
new 722f185ac8 add some TODOs for area cleanup still needed
new f2aaf0bb75 move old base logging.properties out of artemis-cli, but leave it in root for comparison to see needed config updates as others replaced
new 11a2636505 also move the old main tests logging.config file
new 8f6b8850e9 remove various mentions of jblm and wildfly-common from scripts etc, update service config logging details..now to see what it breaks
new 4e445f677d make start on updating remaining integration tests, manipulating levels etc
new bebf88a722 Removing log facade package
new 9a801920f9 Remove slf4j bridge depedencies from libs
new cd786ada61 Moving dependencies as test
new 597bfddfda fixing test
new 3e0479104b Rebased upstream/1662bc740eb4435f5236a70e310825c1daef2e08
new ecbfeaadcb fixing build after rebase
new a62681d2b8 Revert "Remove slf4j bridge depedencies from libs", towards getting build back to consistent deps state and to more easily revert original addition leading to issue.
new b0deddac27 Revert "Moving dependencies as test"
new ed693eb704 Revert "add commons-logging -> SLF4J bridge and exclude commons-logging, suppresses unconfigured log spam from beanutils etc"
new 7aac36f3e7 restore one of the remaining tests using JBL, manipulating levels
new 5d243844ad reinstate another test manipulating levels
new 8dbae6a051 ensure method or class based cleanups for AssertionLoggerHandler exist or will be effective, where startCapture() has been called previously
new c583ea9681 remove rather than reinstate a couple of unnecesarry level manipulations
new dfd7f56a2d update notes
new 29ec97e592 remove now-unused import
new 2999d99369 use latest log4j version
new 2b1f65fb55 update deps to match actual SLF4J base usage and simplify
new 2456ca3351 delete old Log4J 1.x log4j.properties files that shouldnt be doing anything, build isnt using log4j 1.x / reload4j anymore
new a574123705 move karaf server feature test to its own module, its logging deps mess with the commons-config handling
new f3b087f6f6 remove commons-logging slf4j bridge now the karaf bits dont cause beanutils log spam
new d210e75f05 replace logging.properties files for e2e-tests server configs
new c8547c50c8 move another old log config file out to root, for any later comparisons needed
new 6741264882 add another TODO note
new f3603a084f remove uses of JBL from compatibility tests, add artemis-unit-test-support to snapshots CP to ensure test appender class is found and avoids stacktracing
new 8ae5e8797a fixups after rebase to main at 0ca44c0e6972991cf80e5feda34f6d02cf94dea0
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (fbe5b0a222)
\
N -- N -- N refs/heads/new-logging (8ae5e8797a)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 89 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../activemq/artemis/cli/commands/Create.java | 4 +
.../artemis/cli/commands/tools/DBOption.java | 4 +-
.../artemis/cli/commands/tools/PrintData.java | 2 +-
.../artemis/cli/commands/etc/artemis.profile | 2 +-
.../artemis/cli/commands/etc/artemis.profile.cmd | 4 +-
.../activemq/artemis/utils/SelectorTranslator.java | 15 -
.../artemis/utils/actors/ArtemisExecutor.java | 18 ++
.../artemis/utils/actors/OrderedExecutor.java | 17 ++
.../utils/actors/OrderedExecutorFactory.java | 13 +-
.../artemis/utils/actors/ProcessorBase.java | 36 ++-
.../utils/actors/OrderedExecutorSanityTest.java | 63 +++-
.../artemis-hqclient-protocol/pom.xml | 5 +
.../hornetq/HQFilterConversionInterceptor.java | 20 +-
.../protocol/hornetq/SelectorTranslatorTest.java | 54 ++++
.../artemis/core/protocol/mqtt/MQTTLogger.java | 5 +-
.../core/protocol/mqtt/MQTTPublishManager.java | 9 +-
.../artemis/core/protocol/mqtt/MQTTSession.java | 3 +
.../protocol/openwire/OpenWireProtocolManager.java | 68 ++---
.../deployers/impl/FileConfigurationParser.java | 4 +
.../core/management/impl/AddressControlImpl.java | 14 +-
.../paging/cursor/impl/PageCursorProviderImpl.java | 19 +-
.../paging/impl/PagingStoreFactoryDatabase.java | 24 +-
.../core/paging/impl/PagingStoreFactoryNIO.java | 22 +-
.../artemis/core/paging/impl/PagingStoreImpl.java | 28 +-
.../artemis/core/persistence/StorageManager.java | 25 --
.../journal/AbstractJournalStorageManager.java | 26 --
.../impl/journal/JournalStorageManager.java | 8 -
.../impl/nullpm/NullStorageManager.java | 14 -
.../artemis/core/server/ServiceRegistry.java | 6 +
.../core/server/impl/ActiveMQServerImpl.java | 48 ++-
.../artemis/core/server/impl/LastValueQueue.java | 3 +
.../artemis/core/server/impl/QueueImpl.java | 17 +-
.../core/server/impl/ServiceRegistryImpl.java | 12 +
.../core/settings/impl/AddressSettings.java | 33 +-
.../resources/schema/artemis-configuration.xsd | 8 +
.../config/impl/FileConfigurationParserTest.java | 24 ++
.../impl/journal/JournalStorageManagerTest.java | 14 -
.../core/server/files/FileMoveManagerTest.java | 2 +-
.../core/transaction/impl/TransactionImplTest.java | 16 -
artemis-website/pom.xml | 10 +-
docs/user-manual/en/address-settings.md | 8 +
docs/user-manual/en/client-classpath.md | 52 ++--
pom.xml | 6 +-
scripts/one-test.sh | 2 +-
.../transport/amqp/client/AmqpReceiver.java | 4 +
.../amqp/paging/AmqpMaxReadPagingTest.java | 111 +++++++
.../integration/amqp/paging/AmqpPagingTest.java | 11 +-
.../tests/integration/client/SendAckFailTest.java | 15 -
.../failover/LiveCrashOnBackupSyncTest.java | 8 +-
.../integration/management/AddressControlTest.java | 19 +-
.../controlpackets/PublishTestsWithSecurity.java | 47 +++
.../integration/paging/MaxMessagesPagingTest.java | 336 ++++++++++++++++++++-
.../tests/integration/paging/PagingSendTest.java | 28 +-
.../tests/integration/paging/PagingTest.java | 26 +-
.../integration/replication/ReplicationTest.java | 2 +-
.../SharedNothingReplicationFlowControlTest.java | 2 +-
.../artemis/tests/integration/server/LVQTest.java | 22 ++
tests/soak-tests/pom.xml | 35 ++-
.../resources/servers/horizontalPaging}/broker.xml | 72 +++--
.../activemq/artemis/tests/soak/SoakTestBase.java} | 4 +-
.../artemis/tests/soak/TestParameters.java | 59 ++--
.../artemis/tests/soak/client/ClientAbstract.java | 4 -
.../soak/client/ClientNonDivertedSoakTest.java | 11 +-
.../tests/soak/client/ClientParameters.java | 11 +-
.../artemis/tests/soak/client/ClientSoakTest.java | 10 +-
.../artemis/tests/soak/client/Receiver.java | 5 +-
.../soak/failover/RandomFailoverSoakTest.java | 7 +-
.../tests/soak/paging/HorizontalPagingTest.java | 272 +++++++++++++++++
.../src/test/scripts/parameters-paging-short.sh | 50 +++
.../src/test/scripts/parameters-paging.sh | 50 +++
.../core/paging/impl/PagingManagerImplTest.java | 2 +-
.../unit/core/paging/impl/PagingStoreImplTest.java | 40 +--
.../unit/jms/client/SelectorTranslatorTest.java | 31 --
73 files changed, 1591 insertions(+), 490 deletions(-)
create mode 100644 artemis-protocols/artemis-hqclient-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/hornetq/SelectorTranslatorTest.java
create mode 100644 tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/paging/AmqpMaxReadPagingTest.java
copy tests/{smoke-tests/src/main/resources/servers/nettynative => soak-tests/src/main/resources/servers/horizontalPaging}/broker.xml (75%)
copy tests/{smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/common/SmokeTestBase.java => soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/SoakTestBase.java} (98%)
copy artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/RunnableCallback.java => tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/TestParameters.java (50%)
copy artemis-cli/src/main/java/org/apache/activemq/artemis/cli/factory/BrokerFactoryHandler.java => tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/client/ClientParameters.java (66%)
create mode 100644 tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/paging/HorizontalPagingTest.java
create mode 100755 tests/soak-tests/src/test/scripts/parameters-paging-short.sh
create mode 100755 tests/soak-tests/src/test/scripts/parameters-paging.sh