You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shijinkui <gi...@git.apache.org> on 2017/01/25 13:21:27 UTC
[GitHub] flink pull request #3211: c[FLINK-5640][test]onfigure the explicit Unit Test...
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/3211
c[FLINK-5640][test]onfigure the explicit Unit Test file suffix
There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala, *Suite.scala
File name ending with "IT.java" is integration test. File name ending with "Test.java" is unit test.
It's clear for Surefire plugin of default-test execution to declare that "*Test.*" is Java Unit Test.
The test file statistics:
* Suite total: 10
* ITCase total: 378
* Test total: 1008
* ITSuite total: 14
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink defined_ut_suffix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3211.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3211
----
commit aeea3f0b4cd9de5a3ea6a7eb37ce7b70d66d4942
Author: shijinkui <sh...@huawei.com>
Date: 2017-01-25T13:18:13Z
c[FLINK-5640][test]onfigure the explicit Unit Test file suffix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][build]configure the explicit Unit Test file ...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3211
@StephanEwen have finished that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][test]onfigure the explicit Unit Test file su...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3211
cc @rmetzger
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][build]configure the explicit Unit Test file ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3211
Change looks good, thanks!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][test]configure the explicit Unit Test file s...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/3211
@StephanEwen Thank for your quickly reviewing.
>`<include>**/*Test.*</include>`
This can clearly show what unit test's file name like, just like `integration-tests` does. If omitting the `include`, it means that all the class file except `**/*ITCase.*` should be unit test, not only `*Test.*`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3211: [FLINK-5640][build]configure the explicit Unit Tes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][build]configure the explicit Unit Test file ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3211
@shijinkui I think the Unite test include pattern is a good change, would merge that.
Can we exclude the changes to the compiler configuration from the initial change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3211: [FLINK-5640][test]onfigure the explicit Unit Test file su...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3211
Can you briefly explain what this fixes? Currently, it behaves exactly like you describe: The "test" phase executes the `*Test.java` and `*Test.scala` classes, and the "verify" phase executes the `*ITCase.java` and `*ITCase.scala` classes.
Also, the changes to the compiler plugin - what is the purpose and effect of setting it to "verbose"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---