svn commit: r1697351 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/smtp/SMTPClient.java

[se...@apache.org]

Author: sebb
Date: Mon Aug 24 10:30:01 2015
New Revision: 1697351

URL: http://svn.apache.org/r1697351
Log:
NET-580 SMTPClient.sendSimpleMessage() silently ignores failed recipients
Update Javadoc

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPClient.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1697351&r1=1697350&r2=1697351&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml [utf-8] (original)
+++ commons/proper/net/trunk/src/changes/changes.xml [utf-8] Mon Aug 24 10:30:01 2015
@@ -72,6 +72,11 @@ This is mainly a bug-fix release. See fu
   IMAPExportMbox (example app) allows IMAP folders to be exported into an mbox file.
   This is the inverse of the IMAPImportMbox example added previously
         ">
+        
+            <action issue="NET-580" type="fix" dev="sebb" due-to="Simon Arlott">
+            SMTPClient.sendSimpleMessage() silently ignores failed recipients
+            Update Javadoc
+            </action>
             <action issue="NET-579" type="fix" dev="sebb" due-to="Simon Arlott">
             SSL/TLS SocketClients do not verify the hostname against the certificate
             </action>

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPClient.java?rev=1697351&r1=1697350&r2=1697351&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPClient.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPClient.java Mon Aug 24 10:30:01 2015
@@ -442,9 +442,15 @@ public class SMTPClient extends SMTP
      * A convenience method for a sending short email without having to
      * explicitly set the sender and recipient(s).  This method
      * sets the sender and recipients using
-     * {@link #setSender  setSender } and
-     * {@link #addRecipient  addRecipient }, and then sends the
-     * message using {@link #sendShortMessageData  sendShortMessageData }.
+     * {@link #setSender(String)  setSender} and
+     * {@link #addRecipient(String)  addRecipient}, and then sends the
+     * message using {@link #sendShortMessageData(String)  sendShortMessageData}.
+     * <p>
+     * Note that the method ignores failures when calling
+     * {@link #addRecipient(String)  addRecipient} so long as
+     * at least one call succeeds. If no recipients can be successfully
+     * added then the method will fail (and does not attempt to
+     * send the message)
      * <p>
      * @param sender  The email address of the sender.
      * @param recipients  An array of recipient email addresses.