[jira] [Commented] (TEZ-336) AMContainerImpl are stored even after container has completed

["joeyli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736614#comment-13736614 ] 

joeyli commented on TEZ-336:
----------------------------

[#Bikas Saha] I'd like take this up. C_COMPLETED is generated after a container has completed, so I remove the container from containerMap in the handler.

{code:title=AMContainerMap.java|borderStyle=solid}

  public void handle(AMContainerEvent event) {
    AMContainer container = containerMap.get(event.getContainerId());
    if(container != null) {
      container.handle(event);
      // handle C_COMPLETED event: remove container from containerMap
      if (event instanceof AMContainerEventCompleted) {
        remove(event.getContainerId());
        LOG.info("C_COMPLETED envent handled, remove container:" + event.getContainerId());
    }
    } else {
      LOG.info("Event for unknown container: " + event.getContainerId());
    }
  }
{code} 
                
> AMContainerImpl are stored even after container has completed
> -------------------------------------------------------------
>
>                 Key: TEZ-336
>                 URL: https://issues.apache.org/jira/browse/TEZ-336
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>              Labels: TEZ-0.2.0
>             Fix For: 0.2.0
>
>         Attachments: TEZ-336.patch
>
>
> For a long running job thats allocated 100's of 1000's of containers this can be a memory usage issue. Even if AMContainerImpls are small they contain full copies of container launch context objects that look like heavy weights with multiple maps of local resources, env etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira