You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/17 17:34:44 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #9571:
feature/add statsd to charts api
codecov-io commented on issue #9571: feature/add statsd to charts api
URL: https://github.com/apache/incubator-superset/pull/9571#issuecomment-615373659
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=h1) Report
> Merging [#9571](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7b11b44abe08c131fb9df6ec479ea29c24c784ec&el=desc) will **increase** coverage by `4.70%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9571 +/- ##
==========================================
+ Coverage 65.49% 70.20% +4.70%
==========================================
Files 571 182 -389
Lines 29889 17652 -12237
Branches 3040 0 -3040
==========================================
- Hits 19577 12393 -7184
+ Misses 10128 5259 -4869
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `?` | |
| #mysql | `?` | |
| #postgres | `?` | |
| #python | `70.20% <88.88%> (-0.05%)` | :arrow_down: |
| #sqlite | `?` | |
| #unittest | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.17% <88.88%> (+1.42%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.93% <0.00%> (-0.29%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0.00%> (-0.16%)` | :arrow_down: |
| ... and [398 more](https://codecov.io/gh/apache/incubator-superset/pull/9571/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=footer). Last update [7b11b44...43a5ce6](https://codecov.io/gh/apache/incubator-superset/pull/9571?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org