[jira] [Commented] (SENTRY-972) Include sentry-tests-hive hadoop test script in maven project

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028991#comment-15028991 ] 

Hadoop QA commented on SENTRY-972:
----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12774531/SENTRY-972.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/1003/console

This message is automatically generated.

> Include sentry-tests-hive hadoop test script in maven project
> -------------------------------------------------------------
>
>                 Key: SENTRY-972
>                 URL: https://issues.apache.org/jira/browse/SENTRY-972
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Test
>            Reporter: Colm O hEigeartaigh
>            Priority: Trivial
>             Fix For: 1.7.0
>
>         Attachments: SENTRY-972.patch
>
>
> Currently, the sentry-tests-hive module ships a hadoop script in testutils, and uses the maven-antrun-plugin to write and execute a script to copy the hadoop file into "target" and make it executable.
> A better approach would be just to include the script in src/test/resources, and change the permission in the test code to make it executable. This avoids the use of the antrun-plugin + executing a bash script, as well as including the script in the standard maven project structure.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)