You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sakthi (JIRA)" <ji...@apache.org> on 2018/07/02 21:12:00 UTC

[jira] [Comment Edited] (HBASE-20813) Remove RPC quotas when the associated table is dropped off

    [ https://issues.apache.org/jira/browse/HBASE-20813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530444#comment-16530444 ] 

Sakthi edited comment on HBASE-20813 at 7/2/18 9:12 PM:
--------------------------------------------------------

[~mdrob], [~elserj]. I have question. I see that we have a class "MasterSpaceQuotaObserver" that is "observing" the space quota automatic deletion. From here, we could go 2 ways. Either creating a new class naming "MasterThrottleQuotaObserver" or renaming "MasterSpaceQuotaObserver" into "MasterQuotasObserver" and managing in a single class.

I feel, having a separate "observer"(MasterThrottleQuotaObserver) would be more fruitful for us, in case, if we want to add exclusive properties to any specific "observers". What do you guys think?

Note: All of this, while using the same config property.


was (Author: jatsakthi):
[~mdrob], [~elserj]. I have question. I see that we have a class "MasterSpaceQuotaObserver" that is "observing" the space quota management. From here, we could go 2 ways. Either creating a new class naming "MasterThrottleQuotaObserver" or renaming "MasterSpaceQuotaObserver" into "MasterQuotasObserver" and managing in a single class.

I feel, having a separate "observer"(MasterThrottleQuotaObserver) would be more fruitful for us, in case, if we want to add exclusive properties to any specific "observers". What do you guys think?

Note: All of this, while using the same config property.

> Remove RPC quotas when the associated table is dropped off
> ----------------------------------------------------------
>
>                 Key: HBASE-20813
>                 URL: https://issues.apache.org/jira/browse/HBASE-20813
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sakthi
>            Assignee: Sakthi
>            Priority: Minor
>
> In short, the below scenario shouldn't be the case.
> {noformat}
> hbase(main):023:0> create 't2','cf1'
>  Created table t2
>  Took 0.7405 seconds
>  => Hbase::Table - t2
>  hbase(main):024:0>
>  hbase(main):025:0*
>  hbase(main):026:0* set_quota TYPE => THROTTLE, TABLE => 't2', LIMIT => '10M/sec'
>  Took 0.0082 seconds
>  hbase(main):027:0> list_quotas
>  OWNER QUOTAS
>  TABLE => t2 TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT => 10M/sec, SCOPE => MACHINE
>  1 row(s)
>  Took 0.0291 seconds
>  hbase(main):028:0> scan 'hbase:quota'
>  ROW COLUMN+CELL
>  t.t2 column=q:s, timestamp=1530165010888, value=PBUF\x12\x0B\x12\x09\x08\x04\x10\x80\x80\x80\x05 \x02
>  1 row(s)
>  Took 0.0037 seconds
>  hbase(main):029:0> disable 't2'
>  Took 0.4328 seconds
>  hbase(main):030:0> drop 't2'
>  Took 0.2285 seconds
>  hbase(main):031:0> list_quotas
>  OWNER QUOTAS
>  TABLE => t2 TYPE => THROTTLE, THROTTLE_TYPE => REQUEST_SIZE, LIMIT => 10M/sec, SCOPE => MACHINE
>  1 row(s)
>  Took 0.0230 seconds
>  hbase(main):032:0> scan 'hbase:quota'
>  ROW COLUMN+CELL
>  t.t2 column=q:s, timestamp=1530165010888, value=PBUF\x12\x0B\x12\x09\x08\x04\x10\x80\x80\x80\x05 \x02
>  1 row(s)
>  Took 0.0038 seconds
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)