[GitHub] [skywalking] 844067874 commented on pull request #7179: fix the reponse time of gRPC is not right.

[GitBox <gi...@apache.org>]

844067874 commented on pull request #7179:
URL: https://github.com/apache/skywalking/pull/7179#issuecomment-869116479


   I try it in my machine,send much request concurrently,it also throw NPE,i has fixed it,see detail the 
   class `org.apache.skywalking.apm.plugin.grpc.v1.server.TracingServerCallListener`
   ```
   
   @Override
       public void onComplete() {
           super.onComplete();
           asyncSpan.asyncFinish();
       }
   
       @Override
       public void onReady() {
           final AbstractSpan span = ContextManager.createEntrySpan(operation, contextCarrier);
           span.setComponent(ComponentsDefine.GRPC);
           span.setLayer(SpanLayer.RPC_FRAMEWORK);
           contextSnapshot = ContextManager.capture();
           asyncSpan = span.prepareForAsync();
           ContextManager.stopSpan(asyncSpan);
   
           super.onReady();
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org