You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by "Sebastien Richard (JIRA)" <ji...@apache.org> on 2012/11/08 20:12:15 UTC

[jira] [Created] (ANY23-133) Some microdata are rejected even if we ignore errors

Sebastien Richard created ANY23-133:
---------------------------------------

             Summary: Some microdata are rejected even if we ignore errors
                 Key: ANY23-133
                 URL: https://issues.apache.org/jira/browse/ANY23-133
             Project: Apache Any23
          Issue Type: Bug
          Components: core
            Reporter: Sebastien Richard


Proposed patch:

core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java

417,422c394
<                     try {
<                         itemPropValue = getPropertyValue(itemPropNode);
<                     } catch(IllegalArgumentException e) {
<                         throw new MicrodataParserException("Illegal prop content " + e.getMessage(), itemPropNode);
<                     }
---
>                     itemPropValue = getPropertyValue(itemPropNode);


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ANY23-133) Some microdata are rejected even if we ignore errors

Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ANY23-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493433#comment-13493433 ] 

Lewis John McGibbney commented on ANY23-133:
--------------------------------------------

Hi Sebastien, if you are working from Any23 trunk [0] you can simple navigate to the tld and do
{code}
svn diff > ANY23-133.patch
{code}

This will generate a patch which you can then attach to the issue. This way we can cleanly apply patches to our local development Any23 versions.

Thank you 

[0] http://svn.apache.org/repos/asf/any23/trunk/
                
> Some microdata are rejected even if we ignore errors
> ----------------------------------------------------
>
>                 Key: ANY23-133
>                 URL: https://issues.apache.org/jira/browse/ANY23-133
>             Project: Apache Any23
>          Issue Type: Bug
>          Components: core
>            Reporter: Sebastien Richard
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java
> 417,422c394
> <                     try {
> <                         itemPropValue = getPropertyValue(itemPropNode);
> <                     } catch(IllegalArgumentException e) {
> <                         throw new MicrodataParserException("Illegal prop content " + e.getMessage(), itemPropNode);
> <                     }
> ---
> >                     itemPropValue = getPropertyValue(itemPropNode);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ANY23-133) Some microdata are rejected even if we ignore errors

Posted by "Sebastien Richard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ANY23-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493855#comment-13493855 ] 

Sebastien Richard commented on ANY23-133:
-----------------------------------------

Unfortunately I have made several independant fixes in the same file so can't really do that
                
> Some microdata are rejected even if we ignore errors
> ----------------------------------------------------
>
>                 Key: ANY23-133
>                 URL: https://issues.apache.org/jira/browse/ANY23-133
>             Project: Apache Any23
>          Issue Type: Bug
>          Components: core
>            Reporter: Sebastien Richard
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java
> 417,422c394
> <                     try {
> <                         itemPropValue = getPropertyValue(itemPropNode);
> <                     } catch(IllegalArgumentException e) {
> <                         throw new MicrodataParserException("Illegal prop content " + e.getMessage(), itemPropNode);
> <                     }
> ---
> >                     itemPropValue = getPropertyValue(itemPropNode);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (ANY23-133) Some microdata are rejected even if we ignore errors

Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ANY23-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498169#comment-13498169 ] 

Lewis John McGibbney commented on ANY23-133:
--------------------------------------------

Hi Sebasien,
I can't find this snippet of code in the trunk version of Any23... which version are you using please? Also you mention you have numerous independant fixes in your local working copy... would it be possible for you to mention what these are... if so would you be interested in contributing them into Any23?
                
> Some microdata are rejected even if we ignore errors
> ----------------------------------------------------
>
>                 Key: ANY23-133
>                 URL: https://issues.apache.org/jira/browse/ANY23-133
>             Project: Apache Any23
>          Issue Type: Bug
>          Components: core
>            Reporter: Sebastien Richard
>
> Proposed patch:
> core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java
> 417,422c394
> <                     try {
> <                         itemPropValue = getPropertyValue(itemPropNode);
> <                     } catch(IllegalArgumentException e) {
> <                         throw new MicrodataParserException("Illegal prop content " + e.getMessage(), itemPropNode);
> <                     }
> ---
> >                     itemPropValue = getPropertyValue(itemPropNode);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira