You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/12 16:37:59 UTC
[GitHub] [dubbo-samples] wzg547228197 opened a new pull request #254: improve dubbo-samples-tengine test case
wzg547228197 opened a new pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254#issuecomment-760082193
下面的属性应该不需要用到，删除之：
```xml
<slf4j-log4j12.version>1.7.25</slf4j-log4j12.version>
<curator.version>2.12.0</curator.version>
```
dependencyManagement 中加上dubbo-bom后，不需要再添加dubbo的依赖。
请参考文档 https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254#issuecomment-760171401
镜像的问题后面再处理
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on a change in pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
chickenlj commented on a change in pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254#discussion_r557816136
##########
File path: dubbo-samples-tengine/case-configuration.yml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+services:
+ tengine:
+ image: wzg547228197/dubbo-samples-tengine:1.0.0
Review comment:
Agree，如果后面发现这里影响测试速度，可以构建公用镜像
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254#discussion_r556230394
##########
File path: dubbo-samples-tengine/case-configuration.yml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+services:
+ tengine:
+ image: wzg547228197/dubbo-samples-tengine:1.0.0
+ volumes:
+ - ../dubbo-samples-tengine-provider/target/classes/META-INF/docker/nginx.conf:/usr/local/nginx/conf/nginx.conf
Review comment:
使用相对路径不好理解，改成${_basedir}容易理解，只读的文件可以直接挂载src目录中的文件，将nginx.conf移到src/main/resources/docker/tengine/中，上面的挂载可以改成：
${_basedir}/dubbo-samples-tengine-provider/src/main/resources/docker/tengine/nginx.conf:/usr/local/nginx/conf/nginx.conf
##########
File path: dubbo-samples-tengine/pom.xml
##########
@@ -9,6 +9,8 @@
<properties>
<skip_maven_deploy>true</skip_maven_deploy>
<dubbo.version>2.7.7</dubbo.version>
+ <spring-boot.version>2.1.5.RELEASE</spring-boot.version>
+ <dubbo-spring-boot.version>2.7.1</dubbo-spring-boot.version>
Review comment:
没有特别的需要，所有dubbo组件都是使用${dubbo.version}的版本号，这样才能够实现多版本测试。dubbo-spring-boot.version 换成 dubbo.version
##########
File path: dubbo-samples-tengine/pom.xml
##########
@@ -9,6 +9,8 @@
<properties>
<skip_maven_deploy>true</skip_maven_deploy>
<dubbo.version>2.7.7</dubbo.version>
+ <spring-boot.version>2.1.5.RELEASE</spring-boot.version>
+ <dubbo-spring-boot.version>2.7.1</dubbo-spring-boot.version>
Review comment:
dependencyManagement参考文档 https://github.com/apache/dubbo-samples/blob/master/test/convert-case.md#maven%E9%85%8D%E7%BD%AE%E4%BC%98%E5%8C%96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254#discussion_r556236514
##########
File path: dubbo-samples-tengine/case-configuration.yml
##########
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+services:
+ tengine:
+ image: wzg547228197/dubbo-samples-tengine:1.0.0
Review comment:
@chickenlj 建议镜像名字改成xxxx/tengine_with_dubbo 之类的，使用统一账号推送到docker hub
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #254: improve dubbo-samples-tengine test case
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #254:
URL: https://github.com/apache/dubbo-samples/pull/254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org