You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by da...@apache.org on 2019/06/06 18:32:51 UTC

[couchdb] 01/02: Remove debug logging

This is an automated email from the ASF dual-hosted git repository.

davisp pushed a commit to branch prototype/fdb-layer
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit e0b2dc16e2463969eaf7e715b88e130216fba6bb
Author: Paul J. Davis <pa...@gmail.com>
AuthorDate: Thu Jun 6 11:56:58 2019 -0500

    Remove debug logging
---
 src/chttpd/src/chttpd_changes.erl | 8 --------
 src/fabric/src/fabric2_events.erl | 6 +-----
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/src/chttpd/src/chttpd_changes.erl b/src/chttpd/src/chttpd_changes.erl
index 30caab2..620f68d 100644
--- a/src/chttpd/src/chttpd_changes.erl
+++ b/src/chttpd/src/chttpd_changes.erl
@@ -61,7 +61,6 @@ handle_db_changes(Args, Req, Db) ->
     handle_changes(Args, Req, Db, db).
 
 handle_changes(Args1, Req, Db, Type) ->
-    ReqPid = chttpd:header_value(Req, "XKCD", "<unknown>"),
     #changes_args{
         style = Style,
         filter = FilterName,
@@ -69,7 +68,6 @@ handle_changes(Args1, Req, Db, Type) ->
         dir = Dir,
         since = Since
     } = Args1,
-    couch_log:error("XKCD: STARTING CHANGES FEED ~p for ~s : ~p", [self(), ReqPid, Since]),
     Filter = configure_filter(FilterName, Style, Req, Db),
     Args = Args1#changes_args{filter_fun = Filter},
     % The type of changes feed depends on the supplied filter. If the query is
@@ -820,7 +818,6 @@ changes_enumerator(Change0, Acc) ->
             stop -> stop
         end,
         reset_heartbeat(),
-        couch_log:error("XKCD: CHANGE SEQ: ~p", [Seq]),
         {RealGo, Acc#changes_acc{
             seq = Seq,
             user_acc = UserAcc2,
@@ -919,22 +916,17 @@ deleted_item(_) -> [].
 
 % waits for a updated msg, if there are multiple msgs, collects them.
 wait_updated(Timeout, TimeoutFun, UserAcc) ->
-    couch_log:error("XKCD: WAITING FOR UPDATE", []),
     receive
     updated ->
-        couch_log:error("XKCD: GOT UPDATED", []),
         get_rest_updated(UserAcc);
     deleted ->
-        couch_log:error("XKCD: DB DELETED", []),
         {stop, UserAcc}
     after Timeout ->
         {Go, UserAcc2} = TimeoutFun(UserAcc),
         case Go of
         ok ->
-            couch_log:error("XKCD: WAIT UPDATED TIMEOUT, RETRY", []),
             ?MODULE:wait_updated(Timeout, TimeoutFun, UserAcc2);
         stop ->
-            couch_log:error("XKCD: WAIT UPDATED TIMEOUT STOP", []),
             {stop, UserAcc2}
         end
     end.
diff --git a/src/fabric/src/fabric2_events.erl b/src/fabric/src/fabric2_events.erl
index a571714..094ca2f 100644
--- a/src/fabric/src/fabric2_events.erl
+++ b/src/fabric/src/fabric2_events.erl
@@ -43,11 +43,9 @@ stop_listener(Pid) ->
 init(Parent, DbName, Mod, Fun, St) ->
     {ok, Db} = fabric2_db:open(DbName, [?ADMIN_CTX]),
     Since = fabric2_db:get_update_seq(Db),
-    couch_log:error("XKCD: START LISTENER: ~s : ~p for ~p", [DbName, Since, Parent]),
     erlang:monitor(process, Parent),
     Parent ! {self(), initialized},
-    poll(DbName, Since, Mod, Fun, St),
-    couch_log:error("XKCD: STOP LISTENER for ~p", [Parent]).
+    poll(DbName, Since, Mod, Fun, St).
 
 
 poll(DbName, Since, Mod, Fun, St) ->
@@ -56,10 +54,8 @@ poll(DbName, Since, Mod, Fun, St) ->
             {ok, Db} ->
                 case fabric2_db:get_update_seq(Db) of
                     Since ->
-                        couch_log:error("XKCD: NO UPDATE: ~s :: ~p", [DbName, Since]),
                         {{ok, St}, Since};
                     Other ->
-                        couch_log:error("XKCD: UPDATED: ~s :: ~p -> ~p", [DbName, Since, Other]),
                         {Mod:Fun(DbName, updated, St), Other}
                 end;
             Error ->