You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Voldurk (via GitHub)" <gi...@apache.org> on 2024/12/13 12:31:34 UTC
[I] TaskGroup ui_color not rendered in the new graph view [airflow]
Voldurk opened a new issue, #44911:
URL: https://github.com/apache/airflow/issues/44911
### Apache Airflow version
Other Airflow 2 version (please specify below)
### If "Other Airflow 2 version" selected, which one?
2.9.1
### What happened?
The new graph view seems to be ignoring set TaskGroup ui_color value, displays the default
### What you think should happen instead?
Display specified color, as in the old graph view
### How to reproduce
Recreate the following DAG and check its graph view in the UI
```
from datetime import datetime
from airflow.decorators import dag, task_group
from airflow.operators.empty import EmptyOperator
@dag(dag_id="task_group_color", start_date=datetime(2024, 12, 1), schedule=None)
def generate_dag():
@task_group(ui_color="orange")
def group():
EmptyOperator(task_id="task")
group()
generate_dag()
```
### Operating System
composer-2.8.8-airflow-2.9.1
### Versions of Apache Airflow Providers
_No response_
### Deployment
Google Cloud Composer
### Deployment details
_No response_
### Anything else?
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "Voldurk (via GitHub)" <gi...@apache.org>.
Voldurk commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2648457988
It would be great to have it fixed in the earliest possible release of Airflow 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "waqas-saeed (via GitHub)" <gi...@apache.org>.
waqas-saeed commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-3184416014
I'm experiencing the same with Airflow 3.0.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "Voldurk (via GitHub)" <gi...@apache.org>.
Voldurk commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2901083284
@geraj1010 Any luck finding the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color not rendered in the new graph view [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2541347562
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "geraj1010 (via GitHub)" <gi...@apache.org>.
geraj1010 commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2613481597
Interested if nobody is working on it. Should I apply this to both Airflow 2 and 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "geraj1010 (via GitHub)" <gi...@apache.org>.
geraj1010 commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2907556972
> [@geraj1010](https://github.com/geraj1010) Any luck finding the issue?
I did look into it, but ran into a dead end. I asked in our Slack, but did not get a response unfortunately.
Here are my notes:
`I was able to confirm that the ui_color does not change for TaskGroup. I took a look at the class https://github.com/apache/airflow/blob/v2-10-stable/airflow/utils/task_group.py#L715 and I think it has something to do with the task_group_to_dict method. I tried updating the dictionary of the final return (L744) from "style": f"fill:{task_group.ui_color}", to "style": "{background:"f"'{task_group.ui_color}'""}", but that didn't do anything. Interestingly, when I made the same update in the dictionary of the first return (L729), all nodes end up having no color. Is there another place in the codebase that can override the styling of the nodes?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "geraj1010 (via GitHub)" <gi...@apache.org>.
geraj1010 commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-2629928424
Confirming this is also the case with Airflow 2.10.2. I tested with composer-2.10.2-2.10.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on issue #44911:
URL: https://github.com/apache/airflow/issues/44911#issuecomment-4041127621
We intentionally removed this in Airflow 3 to allow the UI to have more opinionated control and to make sure node colors didn't conflict with task state colors.
This is also not a trivial fix for Airflow 2.11 which is on limited support.
Closing this as will not do. Unless someone wants to propose an improved way to manage graph colors in Airflow 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] TaskGroup ui_color ignored by the new graph view [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed issue #44911: TaskGroup ui_color ignored by the new graph view
URL: https://github.com/apache/airflow/issues/44911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org