[jira] [Comment Edited] (AIRFLOW-6985) Airflow should handle the rediss:// protocol for TLS-enable Redis

["Noël BARDELOT (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17058113#comment-17058113 ] 

Noël BARDELOT edited comment on AIRFLOW-6985 at 3/12/20, 5:16 PM:
------------------------------------------------------------------

See also:

https://github.com/mher/flower/pull/938


was (Author: nbardelot):
See also:

https://github.com/NBardelot/flower/commit/a7f8837a9691a8de376989830b03c2daacf537b7

> Airflow should handle the rediss:// protocol for TLS-enable Redis
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-6985
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6985
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: configuration
>    Affects Versions: 1.10.9
>            Reporter: Noël BARDELOT
>            Priority: Major
>
> Please see the following issue for Flower:
> https://github.com/mher/flower/issues/639
> Flower and Airflow do not handle TLS-enable connections to Redis the same way. Thus, when providing the same broker URL to Flower that the one provided to Airflow, Flower cannot start/work.
> There are several issues at hand here:
>   * Airflow by itself does handle its configuration correctly using `ssl_active`, but does not handle `rediss://`
>   * Flower by itself handles `rediss://` but does not handle an additionnal `ssl_active` option
>   * in the Helm chart for Airflow, there is no easy way to provide a configuration to Flower (Flower gets its configuration via the same configuration as Airflow, and thus cannot be correctly configured because Airflow would throw an exception)
> See airflow/config_templates/default_celery.py where an exception is raised if `rediss://` is used.
> A nice and quick fix would be to handle `rediss://` and drive the TLS-enabled mode is that protocol is used while `ssl_active` is also set to true. If `rediss://` is used but `ssl_active` is set to false, an exception could be raised to warn the user that the configuration is inconsistent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)