[GitHub] [incubator-iotdb] LeiRui commented on a change in pull request #180: [IOTDB-95]keep stack trace when logging or throwing an Exception

[GitBox <gi...@apache.org>]

LeiRui commented on a change in pull request #180: [IOTDB-95]keep stack trace when logging or throwing an Exception
URL: https://github.com/apache/incubator-iotdb/pull/180#discussion_r287201238
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/writelog/recover/ExclusiveLogRecoverPerformer.java
 ##########
 @@ -316,9 +314,8 @@ private void replayLog() throws RecoverException {
     try {
       FileNodeManager.getInstance().closeOneFileNode(writeLogNode.getFileNodeName());
     } catch (FileNodeManagerException e) {
-      logger.error("Log node {} cannot perform flush after replaying logs! Because {}",
-          writeLogNode.getIdentifier(), e.getMessage());
-      throw new RecoverException(e);
+      throw new RecoverException(String.format("Log node %s cannot perform flush after replaying logs! Because %s",
+          writeLogNode.getIdentifier(), e.getMessage()), e);
 
 Review comment:
   I am not sure if the e.getMessage() is redundant here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services