You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jeremy Stribling (JIRA)" <ji...@apache.org> on 2011/03/04 22:43:45 UTC
[jira] Created: (ZOOKEEPER-1007) iarchive leak in C client
iarchive leak in C client
-------------------------
Key: ZOOKEEPER-1007
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
Project: ZooKeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.3
Reporter: Jeremy Stribling
Priority: Minor
On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002843#comment-13002843 ]
Hadoop QA commented on ZOOKEEPER-1007:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12472712/zookeeper-1007.patch
against trunk revision 1074995.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/178//console
This message is automatically generated.
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Priority: Minor
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Jeremy Stribling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Stribling updated ZOOKEEPER-1007:
----------------------------------------
Attachment: zookeeper-1007.patch
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Priority: Minor
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007163#comment-13007163 ]
Mahadev konar commented on ZOOKEEPER-1007:
------------------------------------------
thanks jeremy. The patch looks good to me. Ill commit this to trunk.
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch, zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Jeremy Stribling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002849#comment-13002849 ]
Jeremy Stribling commented on ZOOKEEPER-1007:
---------------------------------------------
I'm guessing new tests aren't required for checking memory leaks in error conditions, but if someone disagrees let me know and I'll try to figure out how to write one when I get some time.
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Priority: Minor
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007125#comment-13007125 ]
Hadoop QA commented on ZOOKEEPER-1007:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12473723/zookeeper-1007.patch
against trunk revision 1081896.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/188//console
This message is automatically generated.
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch, zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1007:
-------------------------------------
Fix Version/s: 3.4.0
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-1007:
----------------------------------------
Assignee: Jeremy Stribling
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1007:
-------------------------------------
Attachment: zookeeper-1007.patch
patch against trunk.
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch, zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Jeremy Stribling (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007115#comment-13007115 ]
Jeremy Stribling commented on ZOOKEEPER-1007:
---------------------------------------------
Thanks Mahadev. Anything else you need from me?
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch, zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007014#comment-13007014 ]
Mahadev konar commented on ZOOKEEPER-1007:
------------------------------------------
jeremy, would you be able to create a patch against zookeeper trunk and also relative to zookeeper home directory?
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Priority: Minor
> Attachments: zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ZOOKEEPER-1007) iarchive leak in C client
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007417#comment-13007417 ]
Hudson commented on ZOOKEEPER-1007:
-----------------------------------
Integrated in ZooKeeper-trunk #1123 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1123/])
ZOOKEEPER-1007. iarchive leak in C client (jeremy stribling via mahadev)
> iarchive leak in C client
> -------------------------
>
> Key: ZOOKEEPER-1007
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1007
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3
> Reporter: Jeremy Stribling
> Assignee: Jeremy Stribling
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zookeeper-1007.patch, zookeeper-1007.patch
>
>
> On line 1957, zookeeper_process() returns without cleaning up the "ia" buffer that was previously allocated. I don't know how often this code path is taken, but I thought it was worth reporting. I will attach a simple patch shortly.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira