[GitHub] [incubator-kvrocks] mapleFU commented on a diff in pull request #1428: feat: Catch up `ZRANGE` options

["mapleFU (via GitHub)" <gi...@apache.org>]

mapleFU commented on code in PR #1428:
URL: https://github.com/apache/incubator-kvrocks/pull/1428#discussion_r1186800392


##########
src/types/redis_zset.cc:
##########
@@ -557,7 +558,7 @@ rocksdb::Status ZSet::Remove(const Slice &user_key, const std::vector<Slice> &me
   return storage_->Write(storage_->DefaultWriteOptions(), batch->GetWriteBatch());
 }
 
-rocksdb::Status ZSet::RemoveRangeByScore(const Slice &user_key, ZRangeSpec spec, int *ret) {
+rocksdb::Status ZSet::RemoveRangeByScore(const Slice &user_key, CommonRangeScoreSpec &spec, int *ret) {

Review Comment:
   ```c++
   rocksdb::Status ZSet::RemoveRangeByScore(const Slice &user_key, const CommonRangeScoreSpec &spec, int *ret) {
   ```
   
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org