svn commit: r619724 - /maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java

[jd...@apache.org]

Author: jdcasey
Date: Thu Feb  7 17:20:22 2008
New Revision: 619724

URL: http://svn.apache.org/viewvc?rev=619724&view=rev
Log:
[MNG-2184] Commenting this out again, until I can figure out how to make aggregators run once and only once, regardless of the contents of the reactor.

Modified:
    maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java

Modified: maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java
URL: http://svn.apache.org/viewvc/maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java?rev=619724&r1=619723&r2=619724&view=diff
==============================================================================
--- maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java (original)
+++ maven/components/trunk/maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycleExecutor.java Thu Feb  7 17:20:22 2008
@@ -523,11 +523,15 @@
 
             MojoDescriptor mojoDescriptor = pluginDescriptor.getMojo( mojoBinding.getGoal() );
 
-            if ( mojoDescriptor.isAggregator() && ( project != rm.getTopLevelProject() ) )
-            {
-                getLogger().debug( "Skipping mojo execution: " + MojoBindingUtils.toString( mojoBinding ) + "\nfor project: " + project.getId() + "\n\nIt is an aggregator mojo, and the current project is not the root project for the reactor." );
-                return;
-            }
+            // TODO: Figure out how to make this logic produce the same result when the binding is in a module.
+            // At times, the module will build in isolation, in which case this logic would allow the aggregator to run.
+            // In other cases, the module will be part of a reactor build, and the aggregator won't run, because it's not
+            // bound to the root project.
+//            if ( mojoDescriptor.isAggregator() && ( project != rm.getTopLevelProject() ) )
+//            {
+//                getLogger().debug( "Skipping mojo execution: " + MojoBindingUtils.toString( mojoBinding ) + "\nfor project: " + project.getId() + "\n\nIt is an aggregator mojo, and the current project is not the root project for the reactor." );
+//                return;
+//            }
 
             validateMojoExecution( mojoBinding, mojoDescriptor, project, allowAggregators );