You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Brandon Li <br...@hortonworks.com> on 2015/03/19 18:56:56 UTC
Review Request 32247: Add HDFS-NFS gateway as a new component to HDFS
in Ambari stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/
-----------------------------------------------------------
Review request for Ambari and Alejandro Fernandez.
Bugs: AMBARI-9224
https://issues.apache.org/jira/browse/AMBARI-9224
Repository: ambari
Description
-------
Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
ambari-web/app/data/HDP2/config_mapping.js 1104ceb
Diff: https://reviews.apache.org/r/32247/diff/
Testing
-------
build passed on Apache.
unit tests passed in my local run.
Thanks,
Brandon Li
Re: Review Request 32247: Add HDFS-NFS gateway as a new component to
HDFS in Ambari stack
Posted by Brandon Li <br...@hortonworks.com>.
> On March 19, 2015, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml, line 162
> > <https://reviews.apache.org/r/32247/diff/1/?file=900134#file900134line162>
> >
> > There's a new concept called,
> > <versionAdvertised>true|false</versionAdvertised>
> >
> > If NFS_GATEWAY is part of hdp-select, it should have a value of true.
NFS_GATEWAY is currently not part of hdp-select.
> On March 19, 2015, 6:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py, line 42
> > <https://reviews.apache.org/r/32247/diff/1/?file=900136#file900136line42>
> >
> > During a rolling restart, it will need to call hdp-select on its new version before the service starts. Take a look at other components in HDFS for an example.
NFS_GATEWAY is not part of hdp-select.
- Brandon
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/#review77075
-----------------------------------------------------------
On March 19, 2015, 5:56 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32247/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:56 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-9224
> https://issues.apache.org/jira/browse/AMBARI-9224
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
> ambari-web/app/data/HDP2/config_mapping.js 1104ceb
>
> Diff: https://reviews.apache.org/r/32247/diff/
>
>
> Testing
> -------
>
> build passed on Apache.
> unit tests passed in my local run.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32247: Add HDFS-NFS gateway as a new component to
HDFS in Ambari stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/#review77075
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml
<https://reviews.apache.org/r/32247/#comment124911>
There's a new concept called,
<versionAdvertised>true|false</versionAdvertised>
If NFS_GATEWAY is part of hdp-select, it should have a value of true.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124912>
Only need to import Directory, as opposed to *
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124913>
Prefer to use explicit imports.
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124914>
During a rolling restart, it will need to call hdp-select on its new version before the service starts. Take a look at other components in HDFS for an example.
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124915>
Nice, thanks for adding a unit test.
- Alejandro Fernandez
On March 19, 2015, 5:56 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32247/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:56 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-9224
> https://issues.apache.org/jira/browse/AMBARI-9224
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
> ambari-web/app/data/HDP2/config_mapping.js 1104ceb
>
> Diff: https://reviews.apache.org/r/32247/diff/
>
>
> Testing
> -------
>
> build passed on Apache.
> unit tests passed in my local run.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32247: Add HDFS-NFS gateway as a new component to
HDFS in Ambari stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/#review77108
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 19, 2015, 9:16 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32247/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 9:16 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-9224
> https://issues.apache.org/jira/browse/AMBARI-9224
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
> ambari-web/app/data/HDP2/config_mapping.js 1104ceb
>
> Diff: https://reviews.apache.org/r/32247/diff/
>
>
> Testing
> -------
>
> build passed on Apache.
> unit tests passed in my local run.
>
>
> Thanks,
>
> Brandon Li
>
>
Re: Review Request 32247: Add HDFS-NFS gateway as a new component to
HDFS in Ambari stack
Posted by Brandon Li <br...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/
-----------------------------------------------------------
(Updated March 19, 2015, 9:16 p.m.)
Review request for Ambari and Alejandro Fernandez.
Changes
-------
Add HDFS-NFS gateway as a new component to HDFS in Ambari stack (updated based on Alejandro's comments)
Bugs: AMBARI-9224
https://issues.apache.org/jira/browse/AMBARI-9224
Repository: ambari
Description
-------
Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
ambari-web/app/data/HDP2/config_mapping.js 1104ceb
Diff: https://reviews.apache.org/r/32247/diff/
Testing
-------
build passed on Apache.
unit tests passed in my local run.
Thanks,
Brandon Li
Re: Review Request 32247: Add HDFS-NFS gateway as a new component to
HDFS in Ambari stack
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32247/#review77104
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124994>
from resource_management.libraries.functions.check_process_status import check_process_status
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py
<https://reviews.apache.org/r/32247/#comment124995>
from resource_management.libraries.functions.security_commons import build_expectations, \
cached_kinit_executor, get_params_from_filesystem, validate_security_config_properties, \
FILE_TYPE_XML
- Alejandro Fernandez
On March 19, 2015, 5:56 p.m., Brandon Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32247/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 5:56 p.m.)
>
>
> Review request for Ambari and Alejandro Fernandez.
>
>
> Bugs: AMBARI-9224
> https://issues.apache.org/jira/browse/AMBARI-9224
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari-9224: Add HDFS-NFS gateway as a new component to HDFS in Ambari stack
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml ba9688a
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/nfsgateway.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 6ae9b66
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_nfsgateway.py PRE-CREATION
> ambari-web/app/data/HDP2/config_mapping.js 1104ceb
>
> Diff: https://reviews.apache.org/r/32247/diff/
>
>
> Testing
> -------
>
> build passed on Apache.
> unit tests passed in my local run.
>
>
> Thanks,
>
> Brandon Li
>
>