You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/10 11:52:08 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
HuangXingBo opened a new pull request #12870:
URL: https://github.com/apache/flink/pull/12870
## What is the purpose of the change
*This pull request will extract the implementation logic of Beam in coders*
## Brief change log
- *create a module beam which include the beam related implementations under fn_execution module*
- *extract the beam related implementations from coders*
## Verifying this change
*It is about internal implementations, so previous tests are enough.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656636057
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4510e8f864ba8a613330f7ada8f94eaca559fecc (Fri Jul 10 11:54:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4510e8f864ba8a613330f7ada8f94eaca559fecc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu commented on a change in pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #12870:
URL: https://github.com/apache/flink/pull/12870#discussion_r454080679
##########
File path: flink-python/pyflink/fn_execution/tests/test_process_mode_boot.py
##########
@@ -126,7 +126,10 @@ def test_set_working_directory(self):
fn_execution_dir = os.path.join(pyflink_dir, "fn_execution")
os.mkdir(fn_execution_dir)
open(os.path.join(fn_execution_dir, "__init__.py"), 'a').close()
- with open(os.path.join(fn_execution_dir, "boot.py"), "w") as f:
+ beam_dir = os.path.join(fn_execution_dir, "beam")
+ os.mkdir(beam_dir)
Review comment:
what's the purpose of these two lines:
```
os.mkdir(beam_dir)
open(os.path.join(beam_dir, "__init__.py"), 'a').close()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4510e8f864ba8a613330f7ada8f94eaca559fecc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4510e8f864ba8a613330f7ada8f94eaca559fecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
}, {
"hash" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4510e8f864ba8a613330f7ada8f94eaca559fecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401)
* 7921ed766c2f7bb714d4f9f1fb63818996e4e2ec UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu closed pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12870:
URL: https://github.com/apache/flink/pull/12870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
}, {
"hash" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4413",
"triggerID" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4510e8f864ba8a613330f7ada8f94eaca559fecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401)
* 7921ed766c2f7bb714d4f9f1fb63818996e4e2ec Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4413)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12870: [FLINK-18491][python] Extract the implementation logic of Beam in coders
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12870:
URL: https://github.com/apache/flink/pull/12870#issuecomment-656642305
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4401",
"triggerID" : "4510e8f864ba8a613330f7ada8f94eaca559fecc",
"triggerType" : "PUSH"
}, {
"hash" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4413",
"triggerID" : "7921ed766c2f7bb714d4f9f1fb63818996e4e2ec",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7921ed766c2f7bb714d4f9f1fb63818996e4e2ec Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4413)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org