You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/22 03:26:01 UTC
[GitHub] [skywalking-infra-e2e] mrproliu opened a new pull request #26: Let `compose` support `setup.steps`
mrproliu opened a new pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26
Follow #25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884645370
> As I said, this tool is not always needed in every project
What does this mean exactly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 edited a comment on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884646878
> > As I said, this tool is not always needed in every project
>
> What does this mean exactly?
The softwares installed in `steps` (`yq` in this PR) are not needed in every project. We can not just make them default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884646878
> > As I said, this tool is not always needed in every project
>
> What does this mean exactly?
The softwares installed in `steps` (`yq` in this PR) are not needed in every project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884669626
> As @kezhenxu94 said, If we install it in GHA, there will be a inconsistent between GHA and user’s local environment, as yq is not a default command.
>
> If this tool is always needed OR its our recommended practice to use yaml for verification, maybe we should just include this tool in our `skywalking-infra-e2e` tool, rather than install it?
Could you do more explain what's that mean about include? Users how to use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] Humbertzhang commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
Humbertzhang commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884675184
> Could you do more explain what's that mean about include? Users how to use it?
Maybe we can just take `yq` as a sub command of `e2e`, but this is not a conventional approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884636752
> Should this be the core steps?
It's an optional config for users, If they don't need this, just don't need to set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884639251
> If our verifier needs that, why doesn't it include in default?
> Of course, this feature is necessary, I just ask for more.
There have two reasons:
1. For now, `infra-e2e` just working on the skywalking projects, it's fine. But If some other projects want to use it, maybe the software install is not necessary. So we need to move the as the optional, not include in default.
2. When the user uses the `infra-e2e` maybe they don't install the software for verifying, so we could automatically install some software before running the `verify` phase, users just need to use `e2e setup` to run it for install softwares.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884635486
Then why this supports in compose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884639800
I think yaml or json based verification is always recommended by us. If that tool relates to this, we should make them in default. Otherwise, people and we have to install it one by one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884643798
> I think yaml or json based verification is always recommended by us. If that tool relates to this, we should make them in default. Otherwise, people and we have to install it one by one.
You're right, Should I need to install it to GHA in default? but I think `setup.steps` should also both works in `compose`and `kind`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] Humbertzhang edited a comment on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
Humbertzhang edited a comment on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884675184
> Could you do more explain what's that mean about include? Users how to use it?
Maybe we can just take `yq` as a sub command of `e2e`, this is not a conventional approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884639691
> If our verifier needs that, why doesn't it include in default?
Our (SkyWalking) verifier needs it but not all projects using e2e need it. We don’t want to couple tightly with skywalking no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884635625
Should this be the core steps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884636498
> Then why this supports in compose?
Currently, the `kind` is supported, It also needs to be supported. Because In the `verify` phase It running in the main process, not `compose` pods. So we need to install some software to help `verify`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884644624
Make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884637093
If our verifier needs that, why doesn't it include in default?
Of course, this feature is necessary, I just ask for more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884676485
> > Could you do more explain what's that mean about include? Users how to use it?
>
> Maybe we can just take `yq` as a sub command of `e2e`, but this is not a conventional approach.
Yes, maybe that's a not good practice. If we have other software that needs to be installed, should we also need to add some sub-command?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng merged pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884634592
What is setup step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] Humbertzhang commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
Humbertzhang commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884659680
As @kezhenxu94 said, If we install it in GHA, there will be a inconsistent between GHA and user’s local environment, as yq is not a default command.
If this tool is always needed OR its our recommended practice to use yaml for verification, maybe we should just include this tool in our `skywalking-infra-e2e` tool, rather than install it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 edited a comment on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884646878
> > As I said, this tool is not always needed in every project
>
> What does this mean exactly?
The softwares installed in `steps` (`yq` in this PR) are not needed in every project. We can just make them default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] wu-sheng commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884648027
If that is a part of yaml verifier, from the design level, it is required in default. If there is other case, we could continue to talk about details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884644729
As I said, this tool is not always needed in every project, also installing it in GHA is definitely not acceptable because that would make local test fail and inconsistent with GHA.
No matter how, this PR is needed and you can continue this PR regardless whether we should install the tool by default, it can be done in another PR if conclusion is made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-infra-e2e] mrproliu commented on pull request #26: Let `compose` support `setup.steps`
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #26:
URL: https://github.com/apache/skywalking-infra-e2e/pull/26#issuecomment-884635238
> What is setup step?
That means the user could execute some command in the `setup` phase, such install some software for `verify`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org