[GitHub] [doris] Kikyou1997 commented on a diff in pull request #12433: [fix](Nereids) local aggregate output type is mismatch with BE

[GitBox <gi...@apache.org>]

Kikyou1997 commented on code in PR #12433:
URL: https://github.com/apache/doris/pull/12433#discussion_r964734359


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java:
##########
@@ -1431,7 +1431,7 @@ public void finalizeImplForNereids() throws AnalysisException {
         // TODO: Supports type conversion to match the type of the function's parameters
         if (fnName.getFunction().equalsIgnoreCase("sum")) {
             // Prevent the cast type in vector exec engine
-            Type childType = getChild(0).type.getMaxResolutionType();
+            Type childType = getChild(0).type;

Review Comment:
   Why change this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org