You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2018/11/04 22:02:00 UTC
[jira] [Commented] (GUACAMOLE-651) Preferred image mime format is
ignored by guacamole
[ https://issues.apache.org/jira/browse/GUACAMOLE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674529#comment-16674529 ]
Michael Jumper commented on GUACAMOLE-651:
------------------------------------------
The "image" instruction does not specify the "preferred image mime format". It specifies the formats which the client supports. Further, the instruction is specifically defined with "image/png" and "image/jpeg" being effectively implied. From [http://guacamole.apache.org/doc/gug/protocol-reference.html#image-handshake-instruction] (emphasis added):
{quote}
h2. image
Specifies which image mimetypes are supported by the client. Each parameter must be a single mimetype, listed in order of client preference, with the optimal mimetype being the first parameter. This is the fifth instruction sent during the handshake phase.
*It is expected that the supported mimetypes will include at least "image/png" and "image/jpeg", and the server may safely assume that these mimetypes are supported, even if they are absent from the handshake.*
{quote}
{quote}
Also I am tried with latest github release 1.0.0, the same.
{quote}
You are referring to the "staging/1.0.0" branch, not a release. That branch tracks the source which will ultimately be released when ready, but the 1.0.0 release is still in progress. It has not yet been released.
> Preferred image mime format is ignored by guacamole
> ---------------------------------------------------
>
> Key: GUACAMOLE-651
> URL: https://issues.apache.org/jira/browse/GUACAMOLE-651
> Project: Guacamole
> Issue Type: Bug
> Components: guacamole
> Affects Versions: 0.9.14
> Environment: Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u3 (2018-08-19) x86_64 GNU/Linux
> Reporter: george
> Priority: Major
>
> Reproduce problem:
> Compiled with...
>
> {code:java}
> ....
> Library status:
> freerdp ............. yes
> pango ............... yes
> libavcodec .......... yes
> libavutil ........... yes
> libssh2 ............. yes
> libssl .............. yes
> libswscale .......... yes
> libtelnet ........... yes
> libVNCServer ........ yes
> libvorbis ........... yes
> libpulse ............ yes
> libwebsockets ....... yes
> libwebp ............. yes
> wsock32 ............. no
> Protocol support:
> Kubernetes .... yes
> RDP ........... yes
> SSH ........... yes
> Telnet ........ yes
> VNC ........... yes
> Services / tools:
> guacd ...... yes
> guacenc .... yes
> guaclog .... yes
> {code}
>
>
> Init the connection, handshake, *pass only image/webp*
>
> {code:java}
> [2018-11-04 23:21:13] [Connection 1] Sending opCode: 6.select,3.rdp;
> [2018-11-04 23:21:13] [Connection 1] Sending opCode: 4.size,4.1038,3.813,2.96;
> [2018-11-04 23:21:13] [Connection 1] Sending opCode: 5.audio;
> [2018-11-04 23:21:13] [Connection 1] Sending opCode: 5.video;
> [2018-11-04 23:21:13] [Connection 1] Sending opCode: 5.image,10.image/webp;
> [2018-11-04 23:21:13] [Connection 1] Server sent handshake: 4.args,8.hostname,4.port,6.domain,8.username,8.password,5.width,6.height,3.dpi,15.initial-program,11.color-depth,13.disable-audio,15.enable-printing,12.printer-name,12.enable-drive,10.drive-name,10.drive-path,17.create-drive-path,7.console,13.console-audio,13.server-layout,8.security,11.ignore-cert,12.disable-auth,10.remote-app,14.remote-app-dir,15.remote-app-args,15.static-channels,11.client-name,16.enable-wallpaper,14.enable-theming,21.enable-font-smoothing,23.enable-full-window-drag,26.enable-desktop-composition,22.enable-menu-animations,22.disable-bitmap-caching,25.disable-offscreen-caching,21.disable-glyph-caching,16.preconnection-id,18.preconnection-blob,11.enable-sftp,13.sftp-hostname,13.sftp-host-key,9.sftp-port,13.sftp-username,13.sftp-password,16.sftp-private-key,15.sftp-passphrase,14.sftp-directory,19.sftp-root-directory,26.sftp-server-alive-interval,14.recording-path,14.recording-name,24.recording-exclude-output,23.recording-exclude-mouse,22.recording-include-keys,21.create-recording-path,13.resize-method,18.enable-audio-input,9.read-only,16.gateway-hostname,12.gateway-port,14.gateway-domain,16.gateway-username,16.gateway-password,17.load-balance-info
> ....{code}
>
>
> All is works, but all image data *always compressed as image/png*. Dump from socket...
> {code:java}
> 4.sync,10.5208508175;
> 4.size,2.-1,2.32,2.32;3.img,1.1,2.12,2.-1,9.image/png,1.0,1.0;4.blob,1.1,296.iVBORw0KGgoAAAANSUhEUgAAACAAAAAgCAYAAABzenr0AAAABmJLR0QA/wD/AP+gvaeTAAAAkUlEQVRYhe3WsQ6AIAwE0Nb4/79cBxgMMHDtFZZeQmIcuGeNRJFKpVKp7McyNn1uIyCAmdER6AToCBjARrgATIQbwEKEAAxEGBBFUAARBA3gRbyMYlWdLCIy3VzFPYFFqQ5rKy7AotwdGNDLtV02yLGv4FdOCzqBsTw8BQRAfXL2ptYnAL8m6kF0OyZJ/42p+QBVFjUXpXoKcgAAAABJRU5ErkJggg==;3.end,1.1;6.cursor,2.10,2.10,2.-1,1.0,1.0,2.32,2.32;4.sync,10.5208508204;
> {code}
> Tried with mime/jpeg too, images always compressed with png.
> Also I am tried with latest github release 1.0.0, the same.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)