You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/26 09:20:04 UTC

[GitHub] [camel] jbonofre opened a new pull request #4514: Add composite support in camel-salesforce

jbonofre opened a new pull request #4514:
URL: https://github.com/apache/camel/pull/4514


   Author: Ahmed Ben Salha <ah...@hotmail.com>
   Signed off: JB Onofré <jb...@apache.org>
   
   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] zregvart edited a comment on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
zregvart edited a comment on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716530251


   TLDR, I think this should be done within the existing composite API code. If it remains as is, we will have to maintain two different composite API implementations and two different user experiences.
   
   What we have currently is support for:
   
   - `composite` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_composite.htm)
   - `composite-tree` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobject_tree.htm)
   - `composite-batch` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_batch.htm)
   
   This PR adds support for:
   - upsert functionality of composite collections (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobjects_collections_upsert.htm)
   
   I think we need to be consistent with existing implementation to help minimize the maintenance effort, and consistent with the user experience. To that end:
   
    - I'd like to see this incorporated within the composite support we already have: [CompositeApiProcessor](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/CompositeApiProcessor.java), [CompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/CompositeApiClient.java) and [DefaultCompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/DefaultCompositeApiClient.java).
   
    - The operation should be named something like `composite-collections-upsert` or `composite-collections` with auto-detection (if possible) of sub-operation (create, retreive, update, upsert, delete). 
   
    - I'd also like to see full support for composite collections (can be done over multiple contributions).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-735624516


   By the way, I will remove from the PR the files generated by the maven build.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716514840


   The current "composite" API in the component processes 25 elements with dependencies.
   The "composite" API in this PR processes 200 elements of same type without dependency between them.
   
   So, this PR extends the salesforce component with "new" composite API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716478986


   But we already have composite support, so I don't think we need this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on a change in pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r539038783



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceEndpointConfig.java
##########
@@ -126,6 +127,8 @@
     @UriParam
     private String apexMethod;
     @UriParam
+    private String compositeMethod;

Review comment:
       Like `apexMethod` it's consumer only for now. Let me improve this (we should update `apexMethod` as well but it's another PR).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-727731514


   I'm updating the PR to use better API naming. I will also rebase (to solve conflicts).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-741802892


   I added a documentation. For `compositeMethod`, it's similar to `apexMethod`. Should I mention producer ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-735043179


   Ah my bad, let me change to "upsert_composite_collections" than ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre edited a comment on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre edited a comment on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716515709


   @oscerd @zregvart as explained it's not the same APIs. This PR brings the "new" composite API. As this PR doesn't break anything to the existing, I think it's worth to support it (and not confusing for user, I can improve the documentation anyway).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-734901815


   I renamed the operation to "CompositeBatch" to avoid the confusion. Thoughts ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-741810788


   You are welcome to do it for the options which you in fact know are only either one. So if apex is only producer then you can mark it too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: WIP: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-738593426


   Updated PR after discussion with @zregvart and @jeremyross . I will add `rawPayload` support in other composite operation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-741810319


   @davsclaus yeah, I know. My point is: should I do it only for `compositeMethod` or also for `apexMethod` ? I guess only `compositeMethod` ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716479993


   Let me check, the composite API use was different and not same impl.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-735624068


   @oscerd thanks ! @zregvart thoughts ?
   
   If you are OK, I will merge this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-741816661


   Updated, thanks !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716514199


   I confirm, it's completely different API, not opposite but complement:
   
   https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_composite.htm
   
   https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobjects_collections_upsert.htm


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716515709


   @oscerd @zregvart as explained it's now the same APIs. This PR brings the "new" composite API. As this PR doesn't break anything to the existing, I think it's worth to support it (and not confusing for user, I can improve the documentation anyway).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] zregvart commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716532649


   Within the realm of composite API, Camel is currently missing:
    - composite graphs added in v50 (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_graph_introduction.htm)
    - composite collections added in v42 (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobjects_collections.htm)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] zregvart commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716530251


   TLDR, I think this should be done within the existing composite API code. If it remains as is, we will have to maintain two different composite API implementations and two different user experiences.
   
   What we have currently is support for:
   
   - `composite` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_composite.htm)
   - `composite-tree` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobject_tree.htm)
   - `composite-batch` (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_batch.htm)
   
   This PR adds support for:
   - upsert functionality of composite collections (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/resources_composite_sobjects_collections_upsert.htm)
   
   I think we need to be consistent with existing implementation to help minimize the maintenance effort, and consistent with the user experience. To that end:
   
    - I'd like to see this incorporated within the composite support we already have: [CompositeApiProcessor](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/CompositeApiProcessor.java), [CompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/CompositeApiClient.java) and [DefaultCompositeApiClient](https://github.com/apache/camel/blob/21a3bb6764dba20698693344b1d3caa901d2f8f2/components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/DefaultCompositeApiClient.java).
   
    - The operation should be named something like `composite-collections-upsert` or `composite-collections` with auto-detection (if possible) of sub-operation (create, retreive, update, upsert, delete). 
   
    - I'd also like to see full support for composite collections (individually multiple contributions).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on a change in pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r511821287



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/JsonRestProcessor.java
##########
@@ -98,6 +98,14 @@ protected void processRequest(Exchange exchange) throws SalesforceException {
                 exchange.setProperty(RESPONSE_CLASS, CreateSObjectResult.class);
                 break;
 
+            /**
+             * TODO AHMEDBS

Review comment:
       Please remove todos

##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/XmlRestProcessor.java
##########
@@ -124,6 +124,13 @@ protected void processRequest(Exchange exchange) throws SalesforceException {
                 exchange.setProperty(RESPONSE_CLASS, CreateSObjectResult.class);
                 break;
 
+            /**
+             * TODO AHMEDBS

Review comment:
       Ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] zregvart commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-734963298


   > I renamed the operation to "CompositeBatch" to avoid the confusion. Thoughts ?
   
   Please read the [comment I left earlier](https://github.com/apache/camel/pull/4514#issuecomment-716532649), this adds "upsert functionality of composite collections", we already support composite batch with the operation named `composite-batch`, if anything this adds more confusion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-739694773


   Just updated the test (composite only supports json format (not XML)).
   
   The PR is good to review: `rawPayload` actually makes sense only for `composite` endpoint (as we can do tree or batch directly with `composite`, the user can prepare the body as he wants).
    
   @zregvart @oscerd @jeremyross mind to take a look ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on a change in pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r511876126



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/XmlRestProcessor.java
##########
@@ -124,6 +124,13 @@ protected void processRequest(Exchange exchange) throws SalesforceException {
                 exchange.setProperty(RESPONSE_CLASS, CreateSObjectResult.class);
                 break;
 
+            /**
+             * TODO AHMEDBS

Review comment:
        I will fix. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on a change in pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r538481700



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/DefaultCompositeApiClient.java
##########
@@ -93,6 +93,35 @@ public DefaultCompositeApiClient(final SalesforceEndpointConfig configuration, f
         xStreamCompositeTree.alias("SObjectTreeResponse", SObjectTreeResponse.class);
     }
 
+    public void submitCompositeRaw(
+            final InputStream raw, final Map<String, List<String>> headers,
+            final ResponseCallback<InputStream> callback,
+            final String sObjectName, final String extId, String compositeMethod)
+            throws SalesforceException {
+        checkCompositeFormat(format, SObjectComposite.REQUIRED_PAYLOAD_FORMAT);
+
+        final String url = String.format("%s%s/%s/%s/%s", versionUrl(), "composite", "sobjects", sObjectName, extId);
+
+        System.out.println("URL: " + url);

Review comment:
       Remove system out, or change into a debug LOG

##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/SalesforceEndpointConfig.java
##########
@@ -126,6 +127,8 @@
     @UriParam
     private String apexMethod;
     @UriParam
+    private String compositeMethod;

Review comment:
       Can this be used both on consumer or producer? If not then add label to mark it as consumer or producer only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on a change in pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r511876575



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/processor/JsonRestProcessor.java
##########
@@ -98,6 +98,14 @@ protected void processRequest(Exchange exchange) throws SalesforceException {
                 exchange.setProperty(RESPONSE_CLASS, CreateSObjectResult.class);
                 break;
 
+            /**
+             * TODO AHMEDBS

Review comment:
       I will. Thanks.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #4514:
URL: https://github.com/apache/camel/pull/4514


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-740642550


   @zregvart true ! let me do that ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-741808787


   You actually mark on the @UriParam if its producer or consumer only, by setting label = "producer", label = "consumer" etc. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-735044175


   I updated the PR to use `upsertCompositeSObjects` operation name (to avoid confusion).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716527870


   They are great at naming things :-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] zregvart commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716466732


   @jbonofre have a look at the [integration test](https://github.com/apache/camel/blob/68161be9829f3eb277e5b6fcf51af298d678b045/components/camel-salesforce/camel-salesforce-component/src/test/java/org/apache/camel/component/salesforce/CompositeApiIntegrationTest.java) we have for the composite API support.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre edited a comment on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre edited a comment on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-735043179


   Ah my bad, let me change to "upsert_composite_collections" then ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716481963


   I'd avoid confusion. We already have an implementation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on pull request #4514: [CAMEL-15757] Add composite support in camel-salesforce

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #4514:
URL: https://github.com/apache/camel/pull/4514#issuecomment-716421923


   This PR adds support of Salesforce Composite API. I'm adding a test to show the use case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] jbonofre commented on a change in pull request #4514: [CAMEL-15757] Add rawPayload support in camel-salesforce composite

Posted by GitBox <gi...@apache.org>.
jbonofre commented on a change in pull request #4514:
URL: https://github.com/apache/camel/pull/4514#discussion_r539038308



##########
File path: components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/client/DefaultCompositeApiClient.java
##########
@@ -93,6 +93,35 @@ public DefaultCompositeApiClient(final SalesforceEndpointConfig configuration, f
         xStreamCompositeTree.alias("SObjectTreeResponse", SObjectTreeResponse.class);
     }
 
+    public void submitCompositeRaw(
+            final InputStream raw, final Map<String, List<String>> headers,
+            final ResponseCallback<InputStream> callback,
+            final String sObjectName, final String extId, String compositeMethod)
+            throws SalesforceException {
+        checkCompositeFormat(format, SObjectComposite.REQUIRED_PAYLOAD_FORMAT);
+
+        final String url = String.format("%s%s/%s/%s/%s", versionUrl(), "composite", "sobjects", sObjectName, extId);
+
+        System.out.println("URL: " + url);

Review comment:
       +1 (was debugging)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org