[jira] [Commented] (OFBIZ-12609) ProductWorker getBoolean logic update

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555462#comment-17555462 ] 

ASF subversion and git services commented on OFBIZ-12609:
---------------------------------------------------------

Commit 7bbabc140b0059775835f8c82c816a0f34b6213d in ofbiz-framework's branch refs/heads/release22.01 from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=7bbabc140b ]

Fixed: Backport ProductWorker getBoolean logic update (OFBIZ-12609) (OFBIZ-12649)

If chargeShipping is null (default) the method ProductWorker.shippingApplies
fails.
GenericEntity::getBoolean has changed. If the passed value equals null, false is
returned. ProductWorker expects "null".

jleroux: GenericEntity::getBoolean has been changed for OFBIZ-12386 "Fix some
bugs SpotBugs reports". I checked at least that
"CommunicationEventServices::sendEmailToContactList handles correctly
tmpResult != null". After this fix I have to check other possible similar cases
I neglected. Fortunately, only trunk is concerned.

Thanks: Ingo Wolfmayr


> ProductWorker getBoolean logic update
> -------------------------------------
>
>                 Key: OFBIZ-12609
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-12609
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Upcoming Branch
>            Reporter: Ingo Wolfmayr
>            Assignee: Jacques Le Roux
>            Priority: Major
>             Fix For: Upcoming Branch
>
>         Attachments: pw.patch
>
>
> If chargeShipping is null (default) the method ProductWorker.shippingApplies fails.
> GenericEnity.getBoolean has changed. If the passed value equals null, false is returned.
> ProductWorker expects "null".
> I have attached a patch.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)