You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2023/01/08 12:44:03 UTC
[GitHub] [camel] yasserzamani opened a new pull request, #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
yasserzamani opened a new pull request, #9015:
URL: https://github.com/apache/camel/pull/9015
Invalidates CAMEL-4616.
I think that the test provided by this PR proves that camel JMS doesn't loose messages in transaction when AtiveMQ uses `async send` internally and also asynchronously fails. See the test comments to understand what the pull request does, how, and why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] yasserzamani commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1375322206
@davsclaus by the way, another reason that made me happy to see such exception and to not fix it was that it's an another confirmation and proof for what I'm going to prove with this PR. It showed me that in case of wrong username/password, camel-jms doesn't loose messages when it's in an async transaction send :) maybe I should OR two assertions together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1375301877
Yeah I think its normal, surefire tries 3 times before failing.
It is possible to mark a test to run in isolation if it cannot have other tests run concurrently. That helps in some special tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1374842896
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1374827538
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] yasserzamani commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1375679883
@davsclaus I could fixed it by using a new broker instead of shared one: see #9021 please :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1375277314
I see this error
[ERROR] org.apache.camel.component.jms.issues.AsyncJmsProducerExceptionInTXTest.testAsyncEndpointException Time elapsed: 0.084 s <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <Usage Manager Memory Limit reached on queue://AsyncJmsProducerExceptionInTXTest. See http://activemq.apache.org/producer-flow-control.html for more info> but was: <User name [null] or password is invalid.>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] yasserzamani commented on pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on PR #9015:
URL: https://github.com/apache/camel/pull/9015#issuecomment-1375284084
@davsclaus yes I also saw same thing when I ran camel-jms tests locally on my machine. But I also saw same case for an another test not related at all to my changes (which passed in second run). So I thought maybe it's normal and why camel-jms tries tests multiple times. Should I fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9015: [CAMEL-4616] camel-jms: test not loosing messages in async TX sends
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #9015:
URL: https://github.com/apache/camel/pull/9015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org