You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by brian Foster <ho...@juno.com> on 2012/04/17 00:27:06 UTC
Review Request: Add file staging support to CAS-PGE
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Summary
-------
Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
This addresses bug OODT-443.
https://issues.apache.org/jira/browse/OODT-443
Diffs
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
Diff: https://reviews.apache.org/r/4746/diff
Testing
-------
unit-tests
Thanks,
brian
Re: Review Request: Add file staging support to CAS-PGE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review6966
-----------------------------------------------------------
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4746/#comment15516>
ancillary, but you called it out in your comments, so what can I say :)
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4746/#comment15517>
I think we should put this into an ObjectFactory, that creates new FileStagers by clazzName. Thoughts?
- Chris
On 2012-04-16 22:27:39, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 22:27:39)
>
>
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
>
> - This patch also include minor changes to log statments in PGETaskInstance
>
>
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
>
>
> Diffs
> -----
>
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
> trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4746/diff
>
>
> Testing
> -------
>
> unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Add file staging support to CAS-PGE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review6967
-----------------------------------------------------------
Ship it!
Looks great. My comment is a minor (IMHO) improvement, but if it's too much effort, no worries, +1 anyways. Great work.
- Chris
On 2012-04-16 22:27:39, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> -----------------------------------------------------------
>
> (Updated 2012-04-16 22:27:39)
>
>
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
>
> - This patch also include minor changes to log statments in PGETaskInstance
>
>
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
>
>
> Diffs
> -----
>
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
> trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4746/diff
>
>
> Testing
> -------
>
> unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Add file staging support to CAS-PGE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review7408
-----------------------------------------------------------
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java
<https://reviews.apache.org/r/4746/#comment16337>
Nice, took me a sec to find this! Static method import, win.
- Chris
On 2012-04-30 21:23:30, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> -----------------------------------------------------------
>
> (Updated 2012-04-30 21:23:30)
>
>
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
>
> - This patch also include minor changes to log statments in PGETaskInstance
>
>
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
>
>
> Diffs
> -----
>
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java PRE-CREATION
> trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4746/diff
>
>
> Testing
> -------
>
> unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Add file staging support to CAS-PGE
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review7409
-----------------------------------------------------------
Ship it!
LGTM, thanks bfost!
- Chris
On 2012-04-30 21:23:30, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> -----------------------------------------------------------
>
> (Updated 2012-04-30 21:23:30)
>
>
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
>
> - This patch also include minor changes to log statments in PGETaskInstance
>
>
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
>
>
> Diffs
> -----
>
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java PRE-CREATION
> trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4746/diff
>
>
> Testing
> -------
>
> unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Add file staging support to CAS-PGE
Posted by Paul Ramirez <pr...@jpl.nasa.gov>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/#review7421
-----------------------------------------------------------
Ship it!
- Paul
On 2012-04-30 21:23:30, brian Foster wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4746/
> -----------------------------------------------------------
>
> (Updated 2012-04-30 21:23:30)
>
>
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
>
> - This patch also include minor changes to log statments in PGETaskInstance
>
>
> This addresses bug OODT-443.
> https://issues.apache.org/jira/browse/OODT-443
>
>
> Diffs
> -----
>
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
> trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java PRE-CREATION
> trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4746/diff
>
>
> Testing
> -------
>
> unit-tests
>
>
> Thanks,
>
> brian
>
>
Re: Review Request: Add file staging support to CAS-PGE
Posted by brian Foster <ho...@juno.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/
-----------------------------------------------------------
(Updated 2012-04-30 21:23:30.299369)
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Changes
-------
- updated per chris's request for a GenericPgeObjectFactory
Summary
-------
Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
- This patch also include minor changes to log statments in PGETaskInstance
This addresses bug OODT-443.
https://issues.apache.org/jira/browse/OODT-443
Diffs (updated)
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETask.java 1302648
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java PRE-CREATION
trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
Diff: https://reviews.apache.org/r/4746/diff
Testing
-------
unit-tests
Thanks,
brian
Re: Review Request: Add file staging support to CAS-PGE
Posted by brian Foster <ho...@juno.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4746/
-----------------------------------------------------------
(Updated 2012-04-16 22:27:39.110301)
Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Summary (updated)
-------
Will introduce a FileStaging abstract class with currently 1 implementation using the FileManager. There will also be a new Config object which allow for file paths or product ids which would you like to stage... this code will be plugged in the XML configuration in a separate patch
- This patch also include minor changes to log statments in PGETaskInstance
This addresses bug OODT-443.
https://issues.apache.org/jira/browse/OODT-443
Diffs
-----
trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/FileStagingInfo.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/config/PgeConfig.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/metadata/PgeTaskMetKeys.java 1311492
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileManagerFileStager.java PRE-CREATION
trunk/pge/src/main/java/org/apache/oodt/cas/pge/staging/FileStager.java PRE-CREATION
trunk/pge/src/test/org/apache/oodt/cas/pge/staging/TestFileStager.java PRE-CREATION
Diff: https://reviews.apache.org/r/4746/diff
Testing
-------
unit-tests
Thanks,
brian