You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/29 04:10:16 UTC

[GitHub] [spark] viirya commented on pull request #32699: [SPARK-35560][SQL] Remove redundant subexpression evaluation in nested subexpressions

viirya commented on pull request #32699:
URL: https://github.com/apache/spark/pull/32699#issuecomment-850765540


   > this builds upon/relies upon the common expressions being sorted from your previous MR right?
   
   Yes, if you're asking if this is built on previous PR that sorts subexpressions.
   
   > And theoretically if #32559 hadn't been fixed, this would sort of address that issue by creating a subexpression function for each level that builds on the previous instead of starting from scratch?
   
   Yea, if #32559 is not fixed, this could somehow relieve that but it still suffers from redundant subexpression call if it is split case.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org