You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/06/01 10:11:11 UTC
Re: [PR] fix(vermeer): add Web UI build pipeline [hugegraph-computer]
imbajin commented on code in PR #348:
URL: https://github.com/apache/hugegraph-computer/pull/348#discussion_r3333305534
##########
vermeer/ui/package.json:
##########
@@ -0,0 +1,10 @@
+{
+ "name": "vermeer-ui",
+ "version": "1.0.0",
+ "private": true,
+ "description": "Frontend dependencies for Vermeer UI (downloaded at build time for ASF compliance)",
+ "dependencies": {
+ "jquery": "3.5.1",
Review Comment:
‼️ **Add release metadata for bundled UI assets**
Evidence: this PR adds npm dependencies for jQuery and Bootstrap and downloads Glyphicons/Font Awesome files into the UI bundle, then `go generate` embeds those assets into the Vermeer binary, but the current `LICENSE`/`NOTICE` files do not mention `jquery`, `bootstrap`, `glyphicons`, or `fontawesome`. Impact: release artifacts can redistribute third-party frontend assets without the corresponding ASF license/notice metadata. Please update the release metadata for all bundled UI assets, or change the packaging so these assets are not embedded/distributed.
##########
vermeer/build.sh:
##########
@@ -33,6 +33,12 @@ go mod download
echo "Checking binary dependencies..."
./scripts/download_binaries.sh
+# Download UI assets if not exist
+echo "Checking UI assets..."
+if [ ! -f "ui/ui/lib/.downloaded" ]; then
+ ./scripts/download_ui_assets.sh
+fi
+
# Generate assets if not exist
if [ ! -f "asset/assets_vfsdata.go" ]; then
Review Comment:
‼️ **Regenerate embedded UI assets in build.sh**
Evidence: the documented `./build.sh <arch>` path only runs `go generate` when `asset/assets_vfsdata.go` is missing. Impact: after UI source or downloaded asset changes, the script can still package the stale embedded `assets_vfsdata.go` into the release tarball. Please make this path mirror the Makefile by regenerating assets when inputs change, or always rerun `go generate` before `go build`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org