You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Hsien-Cheng(Ryan) Huang (Jira)" <ji...@apache.org> on 2024/08/08 13:47:00 UTC
[jira] [Updated] (YUNIKORN-2775) Update inaccurate comment regarding regexp
[ https://issues.apache.org/jira/browse/YUNIKORN-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hsien-Cheng(Ryan) Huang updated YUNIKORN-2775:
----------------------------------------------
Description:
After the crowdstrike incident, we know regrex is important for the codebase.
After several code change, comment in this line no longer valid:
https://github.com/apache/yunikorn-core/blob/master/pkg/common/configs/configvalidator.go#L75
suggest change from:
// allow upper and lower case, add the @ and . (dot) and officially no length.
To:
// first char: allow an underscore or a letter, middle: allow letters (uppercase or lowercase), digits, or :, ., _, @, - , allow $ at the end.
was:
After several code change, comment in this line no longer valid:
https://github.com/apache/yunikorn-core/blob/master/pkg/common/configs/configvalidator.go#L75
suggest change from:
// allow upper and lower case, add the @ and . (dot) and officially no length.
To:
// first char: allow an underscore or a letter, middle: allow letters (uppercase or lowercase), digits, or :, ., _, @, - , allow $ at the end.
> Update inaccurate comment regarding regexp
> ------------------------------------------
>
> Key: YUNIKORN-2775
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2775
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - common
> Reporter: Hsien-Cheng(Ryan) Huang
> Assignee: Hsien-Cheng(Ryan) Huang
> Priority: Trivial
>
> After the crowdstrike incident, we know regrex is important for the codebase.
> After several code change, comment in this line no longer valid:
> https://github.com/apache/yunikorn-core/blob/master/pkg/common/configs/configvalidator.go#L75
> suggest change from:
> // allow upper and lower case, add the @ and . (dot) and officially no length.
> To:
> // first char: allow an underscore or a letter, middle: allow letters (uppercase or lowercase), digits, or :, ., _, @, - , allow $ at the end.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org