You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "torwig (via GitHub)" <gi...@apache.org> on 2023/01/27 18:35:12 UTC

[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #1233: Make docker image more portable

torwig commented on code in PR #1233:
URL: https://github.com/apache/incubator-kvrocks/pull/1233#discussion_r1089293228


##########
Dockerfile:
##########
@@ -26,7 +26,7 @@ RUN apt install -y git gcc g++ make cmake autoconf automake libtool python3 libs
 WORKDIR /kvrocks
 
 COPY . .
-RUN ./x.py build -DENABLE_OPENSSL=ON
+RUN ./x.py build -DENABLE_OPENSSL=ON -DPORTABLE=ON

Review Comment:
   Why portable is ON if the binary is built inside Ubuntu and is launching inside Ubuntu?
   I guess arch-specific optimizations could be applied in this case because we are fully aware of the target platform (Ubuntu). Correct me if I'm wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org