[GitHub] [incubator-brpc] Huixxi commented on a change in pull request #1478: bvar supports non-uniform user customized name

[GitBox <gi...@apache.org>]

Huixxi commented on a change in pull request #1478:
URL: https://github.com/apache/incubator-brpc/pull/1478#discussion_r674528929



##########
File path: src/bvar/variable.cpp
##########
@@ -147,12 +150,12 @@ int Variable::expose_impl(const butil::StringPiece& prefix,
     _name.clear();
     _name.reserve((prefix.size() + name.size()) * 5 / 4);
     if (!prefix.empty()) {
-        to_underscored_name(&_name, prefix);
+        g_name_normalization(&_name, prefix);
         if (!_name.empty() && butil::back_char(_name) != '_') {
             _name.push_back('_');

Review comment:
       prefix 和 name 间的 _是总会有的，不包括在名字归一化处理里面的，请问是需要在提交的时候补充说明一下么？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org