You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Ben Pope (JIRA)" <ji...@apache.org> on 2006/04/18 00:39:17 UTC

[jira] Created: (COCOON-1838) Always use 3-digit version number

Always use 3-digit version number
---------------------------------

         Key: COCOON-1838
         URL: http://issues.apache.org/jira/browse/COCOON-1838
     Project: Cocoon
        Type: Improvement

  Components: - Build System: Maven  
    Versions: 2.2-dev (Current SVN)    
    Reporter: Ben Pope
    Priority: Trivial
 Attachments: version.patch

Continuing the theme of Carsten in commit 394739

(This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)

License granted to ASF.

The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1838) Always use 3-digit version number

Posted by "Jorg Heymans (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1838?page=comments#action_12374997 ] 

Jorg Heymans commented on COCOON-1838:
--------------------------------------

It was decided that module poms do not need to carry a 3 digit version number. Their sole responsibility is to group other modules together that make part of a release. In other words, the <version>1-SNAPSHOT</version> should stay. Could you provide an updated patch please ?

> Always use 3-digit version number
> ---------------------------------
>
>          Key: COCOON-1838
>          URL: http://issues.apache.org/jira/browse/COCOON-1838
>      Project: Cocoon
>         Type: Improvement

>   Components: - Build System: Maven
>     Versions: 2.2-dev (Current SVN)
>     Reporter: Ben Pope
>     Priority: Trivial
>  Attachments: version.patch
>
> Continuing the theme of Carsten in commit 394739
> (This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)
> License granted to ASF.
> The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1838) Always use 3-digit version number

Posted by "Reinhard Poetz (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1838?page=comments#action_12412135 ] 

Reinhard Poetz commented on COCOON-1838:
----------------------------------------

If a version or a groupId is missing, the values are taken from the parent artifact. Taking this into consideration, do you know of any other errors?

> Always use 3-digit version number
> ---------------------------------
>
>          Key: COCOON-1838
>          URL: http://issues.apache.org/jira/browse/COCOON-1838
>      Project: Cocoon
>         Type: Improvement

>   Components: - Build System: Maven
>     Versions: 2.2-dev (Current SVN)
>     Reporter: Ben Pope
>     Priority: Trivial
>  Attachments: version.patch
>
> Continuing the theme of Carsten in commit 394739
> (This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)
> License granted to ASF.
> The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (COCOON-1838) Always use 3-digit version number

Posted by "Ben Pope (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1838?page=comments#action_12375010 ] 

Ben Pope commented on COCOON-1838:
----------------------------------

Ah, thats a different story... much harder!

There are a few places where there is a missing groupId or version number altogether.  Is there a maven tool that can check these things or summarise?

I thought it would be an easy patch, but I'm mistaken, I don;t have the time right now to manually check everything, nor do I know if, for example, minimal webapp should be 1 or 1.0.0.

> Always use 3-digit version number
> ---------------------------------
>
>          Key: COCOON-1838
>          URL: http://issues.apache.org/jira/browse/COCOON-1838
>      Project: Cocoon
>         Type: Improvement

>   Components: - Build System: Maven
>     Versions: 2.2-dev (Current SVN)
>     Reporter: Ben Pope
>     Priority: Trivial
>  Attachments: version.patch
>
> Continuing the theme of Carsten in commit 394739
> (This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)
> License granted to ASF.
> The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (COCOON-1838) Always use 3-digit version number

Posted by "Grzegorz Kossakowski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COCOON-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grzegorz Kossakowski closed COCOON-1838.
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.2-dev (Current SVN)

I think this issue is fairly old and we have stabilized builds including versions in our poms so it is safe to close this issue as Ben already said more than a year ago.

> Always use 3-digit version number
> ---------------------------------
>
>                 Key: COCOON-1838
>                 URL: https://issues.apache.org/jira/browse/COCOON-1838
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: - Build System: Maven
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Ben Pope
>            Priority: Trivial
>             Fix For: 2.2-dev (Current SVN)
>
>         Attachments: version.patch
>
>
> Continuing the theme of Carsten in commit 394739
> (This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)
> License granted to ASF.
> The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (COCOON-1838) Always use 3-digit version number

Posted by "Ben Pope (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/COCOON-1838?page=comments#action_12412136 ] 

Ben Pope commented on COCOON-1838:
----------------------------------

A while go I had a look at all the pom files, but I wasn't entirely sure how they worked with respect to the missing version numbers, you've just clarified that.

I have to say that I didn't see any 1 digit version numbers that were not just listing other modules, so I think it's fair to close this issue on that basis.

I do recall seeing some 2 digit version numbers, so it migth be worth checking for those and fixing them.

> Always use 3-digit version number
> ---------------------------------
>
>          Key: COCOON-1838
>          URL: http://issues.apache.org/jira/browse/COCOON-1838
>      Project: Cocoon
>         Type: Improvement

>   Components: - Build System: Maven
>     Versions: 2.2-dev (Current SVN)
>     Reporter: Ben Pope
>     Priority: Trivial
>  Attachments: version.patch
>
> Continuing the theme of Carsten in commit 394739
> (This sits on top of my other patch JIRA 1837, so 1 or two files might fail if that one is not commited)
> License granted to ASF.
> The patch is essentially a search and replace of <version>1-SNAPSHOT</version> and <version>1.0-SNAPSHOT</version> to <version>1.0.0-SNAPSHOT</version>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira