Re: [PR] fix: Fix bug in `array_has` scalar path with sliced arrays [datafusion]

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #20677:
URL: https://github.com/apache/datafusion/pull/20677#discussion_r2880932759


##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -362,7 +360,17 @@ fn array_has_dispatch_for_scalar(
             None,
         )));
     }
-    let eq_array = compare_with_eq(values, needle, is_nested)?;
+
+    // Only compare the visible portion of the values buffer, which avoids

Review Comment:
   maybe we can clarify what is considered as visible?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org