You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/10/01 00:37:50 UTC
[kudu-CR] util: add non-root FindOrCreateMemTracker()
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14321
Change subject: util: add non-root FindOrCreateMemTracker()
......................................................................
util: add non-root FindOrCreateMemTracker()
FindOrCreate() for MemTrackers that aren't children of the root
MemTracker seems like a useful thing to have. For instance, it might be
useful for labeling all the memory tracked for CFileReader with a single
label under a talet's MemTracker.
This patch adds such an atomic method, and adds a test for it.
Change-Id: I8d201a94a44a3eeb6b96173a9ee89440ad1c66ee
---
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
3 files changed, 102 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/14321/1
--
To view, visit http://gerrit.cloudera.org:8080/14321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d201a94a44a3eeb6b96173a9ee89440ad1c66ee
Gerrit-Change-Number: 14321
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] util: add non-root FindOrCreateMemTracker()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has abandoned this change. ( http://gerrit.cloudera.org:8080/14321 )
Change subject: util: add non-root FindOrCreateMemTracker()
......................................................................
Abandoned
Went a different route.
--
To view, visit http://gerrit.cloudera.org:8080/14321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8d201a94a44a3eeb6b96173a9ee89440ad1c66ee
Gerrit-Change-Number: 14321
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] util: add non-root FindOrCreateMemTracker()
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14321
to look at the new patch set (#2).
Change subject: util: add non-root FindOrCreateMemTracker()
......................................................................
util: add non-root FindOrCreateMemTracker()
FindOrCreate() for MemTrackers that aren't children of the root
MemTracker seems like a useful thing to have. For instance, it might be
useful for labeling all the memory tracked for CFileReader with a single
label under a tablet's MemTracker.
This patch adds such an atomic method, and adds a test for it.
Change-Id: I8d201a94a44a3eeb6b96173a9ee89440ad1c66ee
---
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
3 files changed, 102 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/14321/2
--
To view, visit http://gerrit.cloudera.org:8080/14321
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8d201a94a44a3eeb6b96173a9ee89440ad1c66ee
Gerrit-Change-Number: 14321
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>