You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "arunk-kumar (via GitHub)" <gi...@apache.org> on 2026/06/15 10:03:32 UTC
[PR] KNOX-1608: Remove gateway-adapter module [knox]
arunk-kumar opened a new pull request, #1263:
URL: https://github.com/apache/knox/pull/1263
### Jira Link
[KNOX-1608](https://issues.apache.org/jira/browse/KNOX-1608) - Remove gateway-adapter module
## What changes were proposed in this pull request?
As outlined in KNOX-1608, the deprecated `gateway-adapter` module has been completely unhooked from the parent and release build lifecycles, and its directory structure has been completely purged from the codebase.
This module was originally retained as a compatibility bridge for old classpaths (`org.apache.hadoop.gateway`) during historical package migrations and is no longer required for modern deployment targets.
(Please fill in changes proposed in this fix)
## How was this patch tested?
The patch was validated via full workspace compilation from the root directory to confirm that downstream packaging profiles (`gateway-release`, `gateway-docker`) compile cleanly without the module:
`mvn clean install -DskipTests -Dspotbugs.skip=true`
The local build completes successfully with a green `BUILD SUCCESS` flag.
Additionally, a local unit test suite was executed. Flaky tests and environment-specific constraints were observed (notably JaCoCo bytecode mismatches with local JDK 24 and race conditions on high-speed Apple Silicon CPUs), but all core modules and non-environmental test trees compile and validate cleanly.
## Integration Tests
N/A (Codebase technical debt cleanup; no new business logic or operational endpoints introduced).
## UI changes
N/A
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4830297455
## Test Results
28 tests 28 ✅ 3s ⏱️
1 suites 0 💤
1 files 0 ❌
Results for commit 93c366eb.
[test-results]:data:application/gzip;base64,H4sIADEoQmoC/12Myw6CMBBFf4V07YIyUFt/xtBOSSYCNX2siP9uAa3g7p5zk7OwgUYb2K3il4qFRLEAJt9HcnNGyJiPuF6N/MI9JGP+zIOe2dRFDD2NJ2G9d/5jfJpLcd2n4C5+vY0PuY2PNeOmiWIGpsCAEFYrjsJeNVcSUbemQyUbIQEVdChtDez1BquJ2HT/AAAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4847835194
> Thanks @arunk-kumar! can I ask you the motivation behind this change? I would also recommend sending an email on the Knox dev mailing list discussing the change before we make this change (discuss thread). It is unlikely that someone might be using these packages but it is a breaking change and we should let people know before we make these changes.
@arunk-kumar contacted me before he submitted his change and I assured this is ok as we planned to remove this module even earlier, but 3.0.0 will be a breaking change anyway due to the JDK 17 support.
Thanks, @moresandeep, for bringing this up, this was a 100% valid point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 merged PR #1263:
URL: https://github.com/apache/knox/pull/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "smolnar82 (via GitHub)" <gi...@apache.org>.
smolnar82 commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4833374307
> @arunk-kumar Thank you for picking up this task.
>
> * Please rebase the changes you are 14 commits behind `master`.
> * `gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts` still has two `org.apache.hadoop` references please fix those.
Nice catch, @hanicz !
I also found a couple more references to the old package name:
```
$ git status
On branch review-pr-1263
nothing to commit, working tree clean
$ grep -R "org.apache.hadoop.gateway" ./*
./CHANGES: * [KNOX-1553] - Update documentation to reference org.apache.knox instead of org.apache.hadoop.gateway
./build-tools/src/main/resources/build-tools/spotbugs-filter.xml: <Class name="~org.apache.hadoop.gateway..*" />
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts: 'org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm');
./gateway-admin-ui/admin-ui/app/provider-config-wizard/ldap-provider-config.ts: 'org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory');
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch-parameters.xml: <classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/resources/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest/topology-with-dispatch.xml: <classname>org.apache.hadoop.gateway.hbase.HBaseDispatch</classname>
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: " \"main.ldapContextFactory\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\",\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: " \"main.ldapRealm\":\"org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\",\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: " main.ldapRealm: org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: " main.ldapContextFactory: org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory\n" +
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: assertEquals(params.get("main.ldapRealm"), "org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/simple/ProviderConfigurationParserTest.java: assertEquals(params.get("main.ldapContextFactory"), "org.apache.hadoop.gateway.shirorealm.KnoxLdapContextFactory");
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java: assertThat( dispatch.getClassName(), is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-server/src/test/java/org/apache/knox/gateway/topology/xml/TopologyRulesModuleTest.java: assertThat( dispatch.getClassName(), is("org.apache.hadoop.gateway.hbase.HBaseDispatch") );
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt: 62. HADOOP-1504. Fix terminate-org.apache.hadoop-gateway script in contrib/ec2
./gateway-test/src/test/resources/org/apache/knox/gateway/GatewayBasicFuncTest/changes.txt:132. HADOOP-1635. Remove hardcoded keypair name and fix launch-org.apache.hadoop-gateway
./gateway-topology-hadoop-xml/src/test/resources/testDescriptor.xml: authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/resources/testDelete.xml: authentication.param.main.ldapRealm=org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm#
./gateway-topology-hadoop-xml/src/test/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParserTest.java: assertEquals("org.apache.hadoop.gateway.shirorealm.KnoxLdapRealm", authenticationProvider.getParams().get("main.ldapRealm"));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "moresandeep (via GitHub)" <gi...@apache.org>.
moresandeep commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4846492987
Thanks @arunk-kumar! can I ask you the motivation behind this change? I would also recommend sending an email on the Knox dev mailing list discussing the change before we make this change (discuss thread). It is unlikely that someone might be using these packages but it is a breaking change and we should let people know before we make these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "arunk-kumar (via GitHub)" <gi...@apache.org>.
arunk-kumar commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4852447479
Thanks @hanicz, @smolnar82 — rebased on master and cleaned up all remaining org.apache.hadoop.gateway references:
gateway-admin-ui/.../ldap-provider-config.ts — LDAP wizard now emits org.apache.knox.gateway.shirorealm.*
Test fixtures and assertions in gateway-server and gateway-topology-hadoop-xml (topology-with-dispatch{,-parameters}.xml, TopologyRulesModuleTest, ProviderConfigurationParserTest, testDescriptor.xml, testDelete.xml, HadoopXmlResourceParserTest)
Removed the now-dead ~org.apache.hadoop.gateway..* exclusion from spotbugs-filter.xml
Only the KNOX-1553 entry in CHANGES still references the old package, which is a historical release-notes line and shouldn't be rewritten.
@moresandeep — will send a heads-up to dev@knox.apache.org about this being a breaking API change for 3.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KNOX-1608: Remove gateway-adapter module [knox]
Posted by "arunk-kumar (via GitHub)" <gi...@apache.org>.
arunk-kumar commented on PR #1263:
URL: https://github.com/apache/knox/pull/1263#issuecomment-4854740898
Thank you @smolnar82 @hanicz. As per @moresandeep, I've sent a heads-up to dev@knox.apache.org announcing this breaking change for 3.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org