You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by cjpearson <gi...@git.apache.org> on 2015/07/15 17:25:12 UTC
[GitHub] cordova-lib pull request: CB-9371: Don't delete orientation prefer...
GitHub user cjpearson opened a pull request:
https://github.com/apache/cordova-lib/pull/260
CB-9371: Don't delete orientation preferences by default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cjpearson/cordova-lib orientation-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/260.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #260
----
commit a3c86157dd5354db26ba18eabc40cb8eaa8e0351
Author: Connor Pearson <cj...@gmail.com>
Date: 2015-07-15T15:06:09Z
Don't delete orientation preferences by default
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-lib/pull/260
@shazron, could you please take a look at this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9371: Fix prepare deleting orientatio...
Posted by christoph-neumann <gi...@git.apache.org>.
Github user christoph-neumann commented on the pull request:
https://github.com/apache/cordova-lib/pull/260#issuecomment-143048429
This is a needed fix! Why has this not been merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by cjpearson <gi...@git.apache.org>.
Github user cjpearson commented on the issue:
https://github.com/apache/cordova-lib/pull/260
Thanks, @shazron. I've rebased this pr and opened a new one here https://github.com/apache/cordova-ios/pull/233
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9371: Fix prepare deleting orientatio...
Posted by mattrayner <gi...@git.apache.org>.
Github user mattrayner commented on the pull request:
https://github.com/apache/cordova-lib/pull/260#issuecomment-220957152
Is there any news on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/260
I think we can close this since its already in the Platform API for cordova-ios, and users will have to upgrade if they want this fix for cordova-ios < 4.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-9371: Fix prepare deleting orientatio...
Posted by chrskrchr <gi...@git.apache.org>.
Github user chrskrchr commented on the pull request:
https://github.com/apache/cordova-lib/pull/260#issuecomment-167151080
Agreed - this is a useful change. I want to be able to specify different orientation settings for iPhone vs. iPad at the Xcode project level, and this change would allow me to do that without Cordova clobbering my project-level settings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by mattrayner <gi...@git.apache.org>.
Github user mattrayner commented on the issue:
https://github.com/apache/cordova-lib/pull/260
I'm guessing there's no news on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/260
@cjpearson unfortunately this patch can't be applied since the code has changed. Can you re-work it based on the master code? Also, the code you are trying to patch is the default fallback if a platform does not conform to the Platform API (older platforms). For newer platforms that do, like cordova-ios@4.x, they have their own Platform API implementations -- so the corresponding code would exist here: https://github.com/apache/cordova-ios/blob/08e00b68efbf2bfee21866f0bedd9c01ee8255e5/bin/templates/scripts/cordova/lib/prepare.js#L252-L275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #260: CB-9371: Fix prepare deleting orientation pre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/260
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/260
I believe we are deleting ios_parser.js for cordova@7 since that functionality has all been moved into cordova-ios platform now. This would only be useful for older versions of cordova-ios (pre-API.js) now and we are dropping support for those older versions in cordova-7. I think this PR can be closed.
Thoughts @shazron?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #260: CB-9371: Fix prepare deleting orientation preference...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/260
## [Current coverage][cc-pull] is **80.58%**
> Merging [#260][cc-pull] into [master][cc-base-branch] will decrease coverage by **0.01%**
```diff
@@ master #260 diff @@
==========================================
Files 68 68
Lines 5380 5377 -3
Methods 851 851
Messages 0 0
Branches 1038 1038
==========================================
- Hits 4336 4333 -3
Misses 1044 1044
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [e810685...e9261e4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/e810685ce42a6615d62117f026316c9931ad8707...e9261e4cf2a9db0820f9a7667d8639c4bbb47fd8
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/260?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org