You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/24 08:40:25 UTC

[GitHub] cordova-plugin-statusbar pull request: CB-10636 CB-10683 Add JSHin...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/49

    CB-10636 CB-10683 Add JSHint for plugins

    [CB-10636 Add JSHint for plugins](https://issues.apache.org/jira/browse/CB-10636)
    [CB-10683 Fix wrong StatusBar.isVisible initial value on Windows](https://issues.apache.org/jira/browse/CB-10683)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-plugin-statusbar CB-10636

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-statusbar/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit 8a3f9edb9d3a32db89f42e8ae3b08185533dc19c
Author: daserge <v-...@microsoft.com>
Date:   2016-02-24T07:28:04Z

    CB-10636 Add JSHint for plugins

commit bf7869cec7a46e0a538c2e4d61ffa28ddba135cf
Author: daserge <v-...@microsoft.com>
Date:   2016-02-24T07:32:46Z

    CB-10683 Fix wrong StatusBar.isVisible initial value on Windows

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: CB-10636 CB-10683 Add JSHin...

Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-plugin-statusbar/pull/49#issuecomment-189613712
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-statusbar pull request: CB-10636 CB-10683 Add JSHin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-statusbar/pull/49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org