You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/11/15 11:18:27 UTC

[GitHub] [echarts] plainheart opened a new pull request, #17920: fix(pie): fix `center` may not be converted to correct point when coordinate system is specified

plainheart opened a new pull request, #17920:
URL: https://github.com/apache/echarts/pull/17920

   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix a bug that exists in #17132 (v5.4.0)
   
   Due to being normalized to an array, the `center` may not be converted to the correct point when the coordinate system is specified. For example, just like the LngLat array, `center: 'Beijing'` should also be converted to the correct pixel when using the `geo` coordinate system.
   
   ### Fixed issues
   
   - #17132
   
   ## Details
   
   ### Before: What was the problem?
   
   <img src="https://user-images.githubusercontent.com/26999792/201906230-e7ee9232-1bde-43d3-bf87-8b0339ef5931.png" width="600">
   
   ### After: How does it behave after the fixing?
   
   <img src="https://user-images.githubusercontent.com/26999792/201906034-585483a4-80a6-403c-bdef-c77fbadcc029.png" width="600">
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to the 2nd and 7th `test/pie-coordinate-system.html`
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17920: fix(pie): fix `center` may not be converted to correct point when coordinate system is specified

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17920:
URL: https://github.com/apache/echarts/pull/17920#issuecomment-1315167004

   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #17920: fix(pie): fix `center` may not be converted to correct point when coordinate system is specified

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #17920:
URL: https://github.com/apache/echarts/pull/17920#issuecomment-1315172499

   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] plainheart merged pull request #17920: fix(pie): fix `center` may not be converted to correct point when coordinate system is specified

Posted by GitBox <gi...@apache.org>.
plainheart merged PR #17920:
URL: https://github.com/apache/echarts/pull/17920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org