You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by GitBox <gi...@apache.org> on 2018/10/10 22:23:52 UTC
[GitHub] rdelval opened a new pull request #43: Custom executor UI fix
rdelval opened a new pull request #43: Custom executor UI fix
URL: https://github.com/apache/aurora/pull/43
With this patch two things are done:
1. The executor name is exposed through the getTasksWithoutConfigs API. This is necessary for the UI to distinguish between Thermos based executors which expect a certain sandbox layout, and non-thermos based executors which do not have this concept.
This adds minimal overhead (in the case of thermos constant overhead) and doesn't reveal any more information than was previously known or obtainable through the getTaskStatus.
2. Renders links to the thermos observer only if the executor used is thermos.
Used a bold tag when non-thermos tasks are rendered for the Mesos agent address in order to maintain UI consistency.
<img width="1143" alt="screen shot 2018-10-10 at 3 17 09 pm" src="https://user-images.githubusercontent.com/1643994/46769348-59e7d780-cca0-11e8-8b6f-2ac956811205.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services