[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #198: [Baseline] Apply Baseline to iceberg-data #156

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #198: [Baseline] Apply Baseline to iceberg-data #156
URL: https://github.com/apache/incubator-iceberg/pull/198#discussion_r289604331
 
 

 ##########
 File path: data/src/main/java/org/apache/iceberg/data/IcebergGenerics.java
 ##########
 @@ -65,8 +65,8 @@ public ScanBuilder caseInsensitive() {
       return this;
     }
 
-    public ScanBuilder select(String... columns) {
-      this.columns = ImmutableList.copyOf(columns);
+    public ScanBuilder select(String... selectColumns) {
 
 Review comment:
   What about `selectedColumns`? I believe it is frequently used throughout the project.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org