You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Gummadi (Created) (JIRA)" <ji...@apache.org> on 2011/12/09 18:03:39 UTC
[jira] [Created] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
LocalDirAllocator confChanged() accesses conf.get() twice
---------------------------------------------------------
Key: HADOOP-7900
URL: https://issues.apache.org/jira/browse/HADOOP-7900
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 0.24.0, 0.23.1
Environment: mr
Reporter: Ravi Gummadi
Fix For: 0.23.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Ravi Gummadi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-7900:
---------------------------------
Attachment: HADOOP-7900.patch
Attaching patch with trivial fix.
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227218#comment-13227218 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1940 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1940/])
HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299434)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Ravi Gummadi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-7900:
---------------------------------
Status: Patch Available (was: Open)
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227244#comment-13227244 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #680 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/680/])
merge HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299443)
Result = ABORTED
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299443
Files :
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Ravi Gummadi (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-7900:
---------------------------------
Component/s: fs
Description: LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
Environment: (was: mr)
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Fix For: 0.23.1
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227237#comment-13227237 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Common-0.23-Commit #672 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/672/])
merge HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299443)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299443
Files :
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166347#comment-13166347 ]
Hadoop QA commented on HADOOP-7900:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506752/HADOOP-7900.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/456//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/456//console
This message is automatically generated.
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166540#comment-13166540 ]
Robert Joseph Evans commented on HADOOP-7900:
---------------------------------------------
+1 for me too.
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166365#comment-13166365 ]
Uma Maheswara Rao G commented on HADOOP-7900:
---------------------------------------------
{quote}
-1 javadoc. The javadoc tool appears to have generated 5 warning messages.
{quote}
javadoc comments are unrelated to this patch.
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227236#comment-13227236 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Commit #663 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/663/])
merge HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299443)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299443
Files :
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166352#comment-13166352 ]
Uma Maheswara Rao G commented on HADOOP-7900:
---------------------------------------------
+1 lgtm
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7900:
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.24.0
Target Version/s: 0.24.0, 0.23.3
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk and 23 branch.
Thanks a lot Ravi for the patch.
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Ravi Gummadi (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi reassigned HADOOP-7900:
------------------------------------
Assignee: Ravi Gummadi
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.1
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227500#comment-13227500 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Build #223 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/223/])
merge HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299443)
Result = FAILURE
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299443
Files :
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227537#comment-13227537 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1017 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1017/])
HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299434)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227471#comment-13227471 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #982 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/982/])
HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299434)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227477#comment-13227477 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #195 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/195/])
merge HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299443)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299443
Files :
* /hadoop/common/branches/branch-0.23
* /hadoop/common/branches/branch-0.23/hadoop-common-project
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job
* /hadoop/common/branches/branch-0.23/hadoop-project
* /hadoop/common/branches/branch-0.23/hadoop-project/src/site
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Arun C Murthy (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated HADOOP-7900:
----------------------------------
Fix Version/s: (was: 0.23.1)
0.23.3
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227219#comment-13227219 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1865 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1865/])
HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299434)
Result = SUCCESS
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7900) LocalDirAllocator confChanged()
accesses conf.get() twice
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227226#comment-13227226 ]
Hudson commented on HADOOP-7900:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1874 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1874/])
HADOOP-7900. LocalDirAllocator confChanged() accesses conf.get() twice. Contributed by Ravi Gummadi. (Revision 1299434)
Result = ABORTED
umamahesh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1299434
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalDirAllocator.java
> LocalDirAllocator confChanged() accesses conf.get() twice
> ---------------------------------------------------------
>
> Key: HADOOP-7900
> URL: https://issues.apache.org/jira/browse/HADOOP-7900
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.24.0, 0.23.1
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.23.3
>
> Attachments: HADOOP-7900.patch
>
>
> LocalDirAllocator.AllocatorPerContext.confChanged() accesses conf.get() twice unnecessarily. The 2 calls can give 2 different values, which can lead to issues because the first call's return value is saved in savedLocalDirs and is used for comparison in the next call to confChanged() method --- So the comparison is wrong.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira