You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "englefly (via GitHub)" <gi...@apache.org> on 2025/10/09 15:33:25 UTC
[PR] (feat)(nereids) Eager group by [doris]
englefly opened a new pull request, #56764:
URL: https://github.com/apache/doris/pull/56764
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3390007704
<details>
<summary>ClickBench: <b>Total hot run time: 30.68 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8ece7c5ff8f3887410a07675ca452c1c54a9fa2c, data reload: false
query1 0.06 0.06 0.05
query2 0.10 0.06 0.05
query3 0.26 0.08 0.09
query4 1.61 0.12 0.12
query5 0.28 0.26 0.26
query6 1.17 0.66 0.63
query7 0.03 0.02 0.02
query8 0.05 0.04 0.04
query9 0.64 0.52 0.52
query10 0.60 0.57 0.59
query11 0.17 0.12 0.12
query12 0.15 0.12 0.12
query13 0.64 0.62 0.63
query14 1.03 1.04 1.03
query15 0.87 0.89 0.86
query16 0.40 0.40 0.41
query17 1.06 1.05 1.05
query18 0.21 0.20 0.21
query19 1.94 1.92 1.86
query20 0.02 0.01 0.02
query21 15.45 0.94 0.56
query22 0.75 1.27 0.74
query23 14.84 1.38 0.62
query24 7.18 0.95 0.88
query25 0.49 0.20 0.14
query26 0.65 0.16 0.13
query27 0.07 0.06 0.06
query28 9.84 1.38 0.94
query29 12.56 3.91 3.28
query30 0.28 0.14 0.12
query31 2.84 0.60 0.40
query32 3.24 0.56 0.48
query33 3.10 3.13 3.10
query34 15.98 5.47 4.87
query35 4.97 4.90 4.87
query36 0.68 0.52 0.52
query37 0.11 0.07 0.07
query38 0.07 0.05 0.04
query39 0.04 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.03 0.02
query42 0.04 0.03 0.03
query43 0.04 0.04 0.03
Total cold run time: 104.78 s
Total hot run time: 30.68 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3390758326
# FE Regression Coverage Report
Increment line coverage ` 91.16% (299/328)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3388957772
# FE UT Coverage Report
Increment line coverage ` 62.73% (202/322)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_5f3051eea9db378977805ed7ff27f1618dcb299b/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_5f3051eea9db378977805ed7ff27f1618dcb299b/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386674198
<details>
<summary>TPC-DS: <b>Total hot run time: 186312 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8a6c39463aef7d04c60d9d107218254fb5c9dcfa, data reload: false
query1 1065 441 411 411
query2 6567 1740 1702 1702
query3 6761 221 224 221
query4 26502 23920 23414 23414
query5 5808 649 477 477
query6 349 230 244 230
query7 4651 494 306 306
query8 313 254 250 250
query9 8704 2560 2566 2560
query10 542 376 288 288
query11 15596 15010 14830 14830
query12 179 116 112 112
query13 1671 550 424 424
query14 11494 9353 9342 9342
query15 213 200 178 178
query16 7822 693 583 583
query17 1825 852 681 681
query18 2494 450 344 344
query19 229 212 192 192
query20 137 132 129 129
query21 295 134 112 112
query22 4624 4823 4516 4516
query23 30923 30068 30165 30068
query24 8714 2489 2450 2450
query25 626 531 520 520
query26 1255 288 179 179
query27 2921 527 365 365
query28 4411 2216 2182 2182
query29 833 609 503 503
query30 294 224 195 195
query31 895 839 718 718
query32 79 71 65 65
query33 574 382 326 326
query34 812 845 547 547
query35 820 851 751 751
query36 991 1006 931 931
query37 123 113 91 91
query38 3549 3541 3460 3460
query39 1519 1400 1480 1400
query40 229 131 119 119
query41 82 63 64 63
query42 124 122 116 116
query43 499 511 486 486
query44 1312 846 827 827
query45 189 182 178 178
query46 847 995 667 667
query47 1788 1775 1707 1707
query48 388 428 336 336
query49 773 511 441 441
query50 633 695 411 411
query51 3962 3968 3846 3846
query52 114 116 106 106
query53 241 271 206 206
query54 621 600 561 561
query55 90 85 93 85
query56 383 325 306 306
query57 1178 1182 1119 1119
query58 285 272 286 272
query59 2584 2617 2453 2453
query60 358 336 326 326
query61 158 147 152 147
query62 816 733 657 657
query63 229 195 199 195
query64 4436 1152 837 837
query65 4076 4043 3994 3994
query66 1033 438 335 335
query67 15517 15343 14973 14973
query68 9397 949 587 587
query69 536 327 292 292
query70 1223 1088 1051 1051
query71 535 349 326 326
query72 5956 4918 4972 4918
query73 730 634 360 360
query74 8953 9133 8932 8932
query75 4621 3347 2779 2779
query76 3866 1187 742 742
query77 1033 436 335 335
query78 9662 9739 9068 9068
query79 2604 863 597 597
query80 701 563 504 504
query81 492 263 233 233
query82 231 162 131 131
query83 299 280 268 268
query84 304 106 105 105
query85 856 482 426 426
query86 351 316 296 296
query87 3851 3877 3619 3619
query88 2955 2273 2298 2273
query89 437 335 297 297
query90 2057 238 228 228
query91 163 169 135 135
query92 86 69 67 67
query93 2053 1003 635 635
query94 697 436 345 345
query95 412 336 319 319
query96 491 565 282 282
query97 2932 2991 2849 2849
query98 236 217 209 209
query99 1452 1445 1282 1282
Total cold run time: 280297 ms
Total hot run time: 186312 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389852461
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386691177
<details>
<summary>ClickBench: <b>Total hot run time: 29.99 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a6c39463aef7d04c60d9d107218254fb5c9dcfa, data reload: false
query1 0.06 0.05 0.04
query2 0.09 0.05 0.06
query3 0.26 0.09 0.08
query4 1.60 0.12 0.13
query5 0.28 0.26 0.25
query6 1.19 0.65 0.64
query7 0.03 0.03 0.03
query8 0.06 0.04 0.04
query9 0.62 0.52 0.52
query10 0.57 0.61 0.57
query11 0.17 0.12 0.11
query12 0.15 0.12 0.11
query13 0.62 0.61 0.62
query14 1.01 1.04 1.02
query15 0.87 0.84 0.87
query16 0.39 0.39 0.39
query17 1.01 1.04 1.02
query18 0.22 0.20 0.20
query19 1.97 1.84 1.85
query20 0.02 0.01 0.01
query21 15.44 0.93 0.58
query22 0.76 1.17 0.66
query23 14.97 1.41 0.64
query24 7.48 0.88 0.34
query25 0.43 0.24 0.08
query26 0.58 0.16 0.14
query27 0.06 0.06 0.05
query28 9.30 1.41 0.93
query29 12.81 3.90 3.24
query30 0.28 0.13 0.12
query31 2.82 0.61 0.40
query32 3.26 0.56 0.48
query33 3.18 3.20 3.12
query34 16.20 5.55 4.85
query35 4.93 4.95 4.97
query36 0.69 0.53 0.53
query37 0.10 0.08 0.07
query38 0.07 0.05 0.05
query39 0.03 0.03 0.03
query40 0.18 0.16 0.15
query41 0.09 0.04 0.03
query42 0.03 0.03 0.03
query43 0.04 0.03 0.04
Total cold run time: 104.92 s
Total hot run time: 29.99 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386470920
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3388721290
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3392905478
# FE Regression Coverage Report
Increment line coverage ` 91.16% (299/328)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386457594
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389978508
<details>
<summary>TPC-DS: <b>Total hot run time: 186878 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8ece7c5ff8f3887410a07675ca452c1c54a9fa2c, data reload: false
query1 1082 438 418 418
query2 6565 1755 1673 1673
query3 6751 223 217 217
query4 26341 23752 23552 23552
query5 5841 659 501 501
query6 328 262 249 249
query7 4656 509 299 299
query8 297 263 263 263
query9 8734 2557 2571 2557
query10 533 334 284 284
query11 15568 15008 14811 14811
query12 183 123 136 123
query13 1682 567 440 440
query14 12095 9460 9439 9439
query15 239 195 173 173
query16 7760 672 502 502
query17 1600 813 670 670
query18 2078 481 357 357
query19 253 233 198 198
query20 142 131 133 131
query21 232 137 130 130
query22 4639 4742 4636 4636
query23 31285 29944 30005 29944
query24 8817 2542 2550 2542
query25 589 554 514 514
query26 1250 285 171 171
query27 2873 512 366 366
query28 5116 2237 2197 2197
query29 816 656 521 521
query30 331 243 214 214
query31 919 852 790 790
query32 91 77 76 76
query33 596 420 385 385
query34 866 921 560 560
query35 856 844 796 796
query36 1059 1018 979 979
query37 143 127 99 99
query38 3764 3763 3626 3626
query39 1463 1391 1435 1391
query40 223 131 120 120
query41 61 59 60 59
query42 122 114 108 108
query43 512 513 471 471
query44 1366 834 816 816
query45 187 178 180 178
query46 854 998 646 646
query47 1781 1812 1747 1747
query48 399 432 326 326
query49 774 487 411 411
query50 687 696 414 414
query51 3900 3984 3813 3813
query52 108 118 101 101
query53 246 278 197 197
query54 618 599 555 555
query55 95 83 80 80
query56 330 328 308 308
query57 1189 1193 1143 1143
query58 292 278 280 278
query59 2559 2641 2485 2485
query60 369 347 335 335
query61 157 150 154 150
query62 810 719 662 662
query63 227 196 199 196
query64 4425 1164 896 896
query65 4065 3974 3970 3970
query66 1038 426 331 331
query67 15568 15405 15061 15061
query68 8119 955 593 593
query69 500 328 288 288
query70 1161 1070 1069 1069
query71 440 359 321 321
query72 5428 4932 5062 4932
query73 631 586 365 365
query74 9031 8671 9091 8671
query75 3358 3372 2887 2887
query76 3118 1166 754 754
query77 576 446 354 354
query78 9786 9839 8780 8780
query79 2833 860 613 613
query80 1633 592 516 516
query81 557 266 239 239
query82 731 167 137 137
query83 280 284 251 251
query84 259 119 96 96
query85 983 482 423 423
query86 347 319 313 313
query87 3753 3791 3683 3683
query88 4053 2275 2212 2212
query89 399 331 300 300
query90 2107 222 210 210
query91 174 173 163 163
query92 92 71 60 60
query93 2659 1006 642 642
query94 884 438 344 344
query95 399 326 317 317
query96 490 587 283 283
query97 2962 2973 2906 2906
query98 250 214 216 214
query99 1443 1430 1291 1291
Total cold run time: 280831 ms
Total hot run time: 186878 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3393055515
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3390181085
# FE UT Coverage Report
Increment line coverage ` 62.50% (205/328)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly closed pull request #56764: (feat)(nereids) Eager group by
URL: https://github.com/apache/doris/pull/56764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386322028
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3393174182
# FE Regression Coverage Report
Increment line coverage ` 91.16% (299/328)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_8ece7c5ff8f3887410a07675ca452c1c54a9fa2c_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389782013
# FE Regression Coverage Report
Increment line coverage ` 90.99% (293/322)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_5f3051eea9db378977805ed7ff27f1618dcb299b_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_5f3051eea9db378977805ed7ff27f1618dcb299b_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389805353
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386320744
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3392762187
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389102041
<details>
<summary>ClickBench: <b>Total hot run time: 30.05 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f3051eea9db378977805ed7ff27f1618dcb299b, data reload: false
query1 0.06 0.05 0.05
query2 0.09 0.05 0.06
query3 0.24 0.09 0.08
query4 1.61 0.12 0.12
query5 0.29 0.27 0.25
query6 1.20 0.66 0.65
query7 0.03 0.02 0.02
query8 0.06 0.04 0.05
query9 0.62 0.53 0.52
query10 0.58 0.57 0.59
query11 0.19 0.11 0.11
query12 0.15 0.12 0.12
query13 0.63 0.62 0.61
query14 1.05 1.04 1.03
query15 0.86 0.86 0.86
query16 0.42 0.41 0.40
query17 1.07 1.06 1.05
query18 0.21 0.20 0.19
query19 1.99 1.84 1.86
query20 0.02 0.01 0.02
query21 15.41 0.90 0.58
query22 0.75 1.06 0.70
query23 14.97 1.31 0.64
query24 7.49 1.40 0.49
query25 0.48 0.14 0.09
query26 0.69 0.16 0.13
query27 0.06 0.06 0.05
query28 9.16 1.34 0.93
query29 12.54 3.85 3.27
query30 0.27 0.13 0.11
query31 2.83 0.62 0.39
query32 3.24 0.55 0.48
query33 3.15 3.02 3.14
query34 15.99 5.42 4.84
query35 4.92 4.90 4.90
query36 0.67 0.52 0.49
query37 0.10 0.07 0.08
query38 0.07 0.05 0.04
query39 0.03 0.03 0.03
query40 0.18 0.15 0.14
query41 0.09 0.04 0.03
query42 0.04 0.04 0.03
query43 0.04 0.04 0.03
Total cold run time: 104.54 s
Total hot run time: 30.05 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389856442
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #56764:
URL: https://github.com/apache/doris/pull/56764#discussion_r2425116609
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/PushDownAggContext.java:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.eageraggregation;
+
+import org.apache.doris.nereids.CascadesContext;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.functions.agg.AggregateFunction;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+
+import java.util.LinkedHashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+/**
+ * PushDownAggContext
+ */
+public class PushDownAggContext {
+ private final List<AggregateFunction> aggFunctions;
+ private final List<NamedExpression> groupKeys;
+ private final Map<AggregateFunction, Alias> aliasMap;
+ private final Set<Slot> aggFunctionsInputSlots;
+
+ // the group keys that eventually used to generate aggregation node
+ private final LinkedHashSet<SlotReference> finalGroupKeys = new LinkedHashSet<>();
+
+ // cascadesContext is used for normalizeAgg
+ private final CascadesContext cascadesContext;
+
+ /**
+ * constructor
+ */
+ public PushDownAggContext(List<AggregateFunction> aggFunctions,
+ List<NamedExpression> groupKeys,
+ CascadesContext cascadesContext) {
+ this(aggFunctions, groupKeys, null, cascadesContext);
+ }
+
+ /**
+ * constructor
+ */
+ public PushDownAggContext(List<AggregateFunction> aggFunctions,
+ List<NamedExpression> groupKeys, Map<AggregateFunction, Alias> aliasMap, CascadesContext cascadesContext) {
+ this.groupKeys = groupKeys;
+ this.aggFunctions = ImmutableList.copyOf(aggFunctions);
+ this.cascadesContext = cascadesContext;
+
+ if (aliasMap == null) {
+ ImmutableMap.Builder<AggregateFunction, Alias> aliasMapBuilder = ImmutableMap.builder();
+ for (AggregateFunction aggFunction : this.aggFunctions) {
+ Alias alias = new Alias(aggFunction, aggFunction.getName());
+ aliasMapBuilder.put(aggFunction, alias);
+ }
+ this.aliasMap = aliasMapBuilder.build();
+ } else {
+ this.aliasMap = aliasMap;
+ }
+
+ this.aggFunctionsInputSlots = aggFunctions.stream()
+ .flatMap(aggFunction -> aggFunction.getInputSlots().stream())
+ .filter(Slot.class::isInstance)
+ .collect(ImmutableSet.toImmutableSet());
+ }
+
+ public Map<AggregateFunction, Alias> getAliasMap() {
+ return aliasMap;
+ }
+
+ public List<AggregateFunction> getAggFunctions() {
+ return aggFunctions;
+ }
+
+ public List<NamedExpression> getGroupKeys() {
+ return groupKeys;
+ }
+
+ public PushDownAggContext withGoupKeys(List<NamedExpression> groupKeys) {
Review Comment:
Corrected spelling of 'withGoupKeys' to 'withGroupKeys'.
```suggestion
public PushDownAggContext withGroupKeys(List<NamedExpression> groupKeys) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/PushDownAggregation.java:
##########
@@ -0,0 +1,243 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
Review Comment:
The Apache license header is duplicated at the beginning of the file. The second copy (lines 18-33) should be removed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly closed pull request #56764: (feat)(nereids) Eager group by
URL: https://github.com/apache/doris/pull/56764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3386768410
# FE UT Coverage Report
Increment line coverage ` 64.09% (207/323)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/56764_8a6c39463aef7d04c60d9d107218254fb5c9dcfa/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/56764_8a6c39463aef7d04c60d9d107218254fb5c9dcfa/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] (feat)(nereids) Eager group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #56764:
URL: https://github.com/apache/doris/pull/56764#issuecomment-3389083793
<details>
<summary>TPC-DS: <b>Total hot run time: 186262 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f3051eea9db378977805ed7ff27f1618dcb299b, data reload: false
query1 1060 458 430 430
query2 6567 1711 1752 1711
query3 6752 227 228 227
query4 26697 24086 23144 23144
query5 5475 649 471 471
query6 350 250 224 224
query7 4662 488 296 296
query8 322 272 259 259
query9 8719 2588 2569 2569
query10 554 333 312 312
query11 15454 15061 14842 14842
query12 186 124 116 116
query13 1683 572 440 440
query14 11660 9428 9323 9323
query15 268 186 171 171
query16 7797 645 550 550
query17 1624 771 619 619
query18 2168 449 352 352
query19 279 214 211 211
query20 146 137 132 132
query21 214 159 134 134
query22 4797 4647 4609 4609
query23 30990 30194 30168 30168
query24 8496 2488 2495 2488
query25 587 537 465 465
query26 1238 283 180 180
query27 2989 528 374 374
query28 4404 2210 2259 2210
query29 800 665 533 533
query30 308 252 227 227
query31 961 1044 830 830
query32 86 72 69 69
query33 577 387 329 329
query34 818 898 537 537
query35 851 890 754 754
query36 948 1034 926 926
query37 121 108 86 86
query38 3483 3619 3551 3551
query39 1475 1394 1398 1394
query40 224 122 111 111
query41 76 60 58 58
query42 123 106 105 105
query43 486 503 451 451
query44 1319 813 820 813
query45 189 178 172 172
query46 833 988 632 632
query47 1760 1800 1727 1727
query48 395 436 313 313
query49 763 515 422 422
query50 654 686 400 400
query51 3901 3918 3829 3829
query52 105 104 97 97
query53 236 276 191 191
query54 603 588 529 529
query55 92 83 85 83
query56 314 314 304 304
query57 1166 1215 1121 1121
query58 291 275 284 275
query59 2536 2765 2518 2518
query60 338 331 312 312
query61 146 146 153 146
query62 793 730 673 673
query63 229 194 190 190
query64 4439 1145 805 805
query65 4095 3936 4008 3936
query66 1041 431 350 350
query67 15721 15183 15037 15037
query68 8700 966 591 591
query69 521 323 291 291
query70 1251 1115 1099 1099
query71 520 408 300 300
query72 5820 4852 4896 4852
query73 728 604 359 359
query74 8936 8836 8941 8836
query75 4273 3325 2834 2834
query76 3798 1187 745 745
query77 843 407 373 373
query78 9706 9871 8937 8937
query79 2108 804 593 593
query80 621 622 498 498
query81 508 257 229 229
query82 457 156 133 133
query83 266 283 272 272
query84 267 108 88 88
query85 856 478 418 418
query86 381 321 306 306
query87 3762 3801 3676 3676
query88 3563 2261 2218 2218
query89 388 330 325 325
query90 1993 234 229 229
query91 175 171 130 130
query92 84 63 68 63
query93 1637 1010 646 646
query94 691 478 346 346
query95 399 317 317 317
query96 497 558 278 278
query97 2934 2974 2905 2905
query98 245 227 206 206
query99 1692 1419 1306 1306
Total cold run time: 278054 ms
Total hot run time: 186262 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org